+++ This bug was initially created as a clone of Bug #1164778 +++ Description of problem: Gluster volume smb share options are getting overwritten whenever we restart the volume. Version-Release number of selected component (if applicable): mainline How reproducible: Always Steps to Reproduce: 1. Modify any of the field from gluster volume share in /etc/samba/smb.conf 2. Like "read only" = "no" to "yes" 3. Stop and start the volume 4. It will again become "read only" = "no" Actual results: Changed configuration parameters are coming back to default value Expected results: They should not Additional info: This is happening because we delete all gluster volume share at the time of stopping the volume with help of gluster smb hook scripts and again we freshly create these gluster volume shares when we start the volume.
https://review.gluster.org/#/c/19750/
REVIEW: https://review.gluster.org/19750 (extras/hooks: Do not blindly remove volume share from smb.conf) posted (#2) for review on master by Anoop C S
COMMIT: https://review.gluster.org/19750 committed in master by "Poornima G" <pgurusid> with a commit message- extras/hooks: Do not blindly remove volume share from smb.conf When Gluster volumes are shared via Samba, any extra smb.conf parameter setting done by administrator to those shares are lost during restart of the volume. Instead of removing the whole share completely from smb.conf(via hook scripts during volume stop) it is better to make it temporarily unavailable to end-users till the volume is started again. Therefore we make use of a smb.conf parameter named 'available'[1] to achieve the above intend. [1] https://www.samba.org/samba/docs/current/man-html/smb.conf.5.html Change-Id: I68a9055b50791f6ffd3b95a3c13d858a75fa6530 fixes: bz#1558921 BUG: 1558921 Signed-off-by: Anoop C S <anoopcs>
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-5.0, please open a new bug report. glusterfs-5.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution. [1] https://lists.gluster.org/pipermail/announce/2018-October/000115.html [2] https://www.gluster.org/pipermail/gluster-users/