Bug 1559362 - The import cluster job should be marked finished in import cluster flow
Summary: The import cluster job should be marked finished in import cluster flow
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Gluster Storage
Classification: Red Hat Storage
Component: web-admin-tendrl-commons
Version: rhgs-3.4
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
: RHGS 3.4.0
Assignee: Shubhendu Tripathi
QA Contact: Filip Balák
URL:
Whiteboard:
Depends On:
Blocks: 1503137
TreeView+ depends on / blocked
 
Reported: 2018-03-22 11:55 UTC by Shubhendu Tripathi
Modified: 2018-09-04 07:02 UTC (History)
5 users (show)

Fixed In Version: tendrl-commons-1.6.1-3.el7rhgs
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-09-04 07:00:53 UTC
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github https://github.com/Tendrl commons issues 864 0 None None None 2018-03-28 12:29:51 UTC
Red Hat Product Errata RHSA-2018:2616 0 None None None 2018-09-04 07:02:03 UTC

Description Shubhendu Tripathi 2018-03-22 11:55:59 UTC
Description of problem:
Currently the import cluster job is marked as finished under ConfigureMonitoring atom of the flow. The same should happen in the main flow.

Version-Release number of selected component (if applicable):


How reproducible:
Always

Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 2 Martin Bukatovic 2018-03-28 09:30:20 UTC
Could you provide more details about:

* Link to upstream merge request or issue.
* Reproducer scenario, QE team has no idea how to test this.
* Version where the bug is present.
* Is it possible to reproduce this on previously released RHGS WA?

Comment 3 Shubhendu Tripathi 2018-03-28 12:29:52 UTC
>> Link to upstream merge request or issue
Done

>> Reproducer scenario, QE team has no idea how to test this
This ideally doesn't have any end user impact as such. Its just like sometimes you feel that import cluster job was getting completed but actually the first round of sync was not yet over and cluster is actually not ready to use in UI.

>> Version where the bug is present
The version 1.6.1-1 had this but as I told earlier it wont be visibly testable scenario but as a back-end task it should be done this was. We should not finish the task just if at certain stage an atomic portion of the task is executed (and still there are few verification atoms pending execution).

>> Is it possible to reproduce this on previously released RHGS WA
As told earlier its really not easily visibly producable scenario.

Comment 4 Martin Bukatovic 2018-03-28 14:44:29 UTC
Based on the information provided, qe team can't subscribe to test this BZ.

Comment 5 RHEL Program Management 2018-03-28 14:53:04 UTC
Quality Engineering Management has reviewed and declined this request.
You may appeal this decision by reopening this request.

Comment 6 Shubhendu Tripathi 2018-03-28 15:02:26 UTC
Martin, but based on this do you really feel we don't fix these kind of framework/flow related issues at all? Personally I don't agree to this.

Comment 7 Nishanth Thomas 2018-03-28 15:15:46 UTC
This Fix is required because in some scenarios(when the import fails, when retry multiple times), the main job is not marked as completed. This blocks further jobs to be initiated from the UI. The use case is import failure case.

Comment 9 Martin Bukatovic 2018-03-29 07:46:10 UTC
I'm going to provide conditional qe_ack with following assumptions:

* dev team must have done code walkthrough or sanity unit validation of
  the change described in this BZ
* qe team will verify this BZ by running general regression tests which
  covers import scenarios

Does dev team agree?

Comment 10 Nishanth Thomas 2018-03-29 08:08:41 UTC
Ack

Comment 14 Filip Balák 2018-08-08 13:20:03 UTC
Import cluster is marked correctly as finished when cluster is imported and failed when import job fails. --> VERIFIED

There were tested import jobs with volumes and combinations of volumes defined by configuration files in https://github.com/usmqe/usmqe-setup/tree/master/gdeploy_config. There were tested also negative import test cases with broken repo url or missing nodes. In these cases the jobs finished as expected. In rare scenario job finishes when there was some problem during import (BZ 1571244 and BZ 1602858) and in rare scenario there is an error during import (BZ 1613853).

Tested with:
tendrl-ansible-1.6.3-6.el7rhgs.noarch
tendrl-api-1.6.3-5.el7rhgs.noarch
tendrl-api-httpd-1.6.3-5.el7rhgs.noarch
tendrl-commons-1.6.3-11.el7rhgs.noarch
tendrl-grafana-plugins-1.6.3-8.el7rhgs.noarch
tendrl-grafana-selinux-1.5.4-2.el7rhgs.noarch
tendrl-monitoring-integration-1.6.3-8.el7rhgs.noarch
tendrl-node-agent-1.6.3-9.el7rhgs.noarch
tendrl-notifier-1.6.3-4.el7rhgs.noarch
tendrl-selinux-1.5.4-2.el7rhgs.noarch
tendrl-ui-1.6.3-9.el7rhgs.noarch

Comment 16 errata-xmlrpc 2018-09-04 07:00:53 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2018:2616


Note You need to log in before you can comment on or make changes to this bug.