Created attachment 1436787 [details]
Brick Details page with filter

There are correctly added basic filters but there are missing 2 filter options from design:
 * Utilization More Than
 * Utilization Less Than

There is also not shown number of bricks that are down and `Failed Only` filter is missing.
--> ASSIGNED


Tested with:
tendrl-ansible-1.6.3-3.el7rhgs.noarch
tendrl-api-1.6.3-3.el7rhgs.noarch
tendrl-api-httpd-1.6.3-3.el7rhgs.noarch
tendrl-commons-1.6.3-4.el7rhgs.noarch
tendrl-grafana-plugins-1.6.3-2.el7rhgs.noarch
tendrl-grafana-selinux-1.5.4-2.el7rhgs.noarch
tendrl-gluster-integration-1.6.3-2.el7rhgs.noarch
tendrl-monitoring-integration-1.6.3-2.el7rhgs.noarch
tendrl-node-agent-1.6.3-4.el7rhgs.noarch
tendrl-notifier-1.6.3-2.el7rhgs.noarch
tendrl-selinux-1.5.4-2.el7rhgs.noarch
tendrl-ui-1.6.3-1.el7rhgs.noarch

Created attachment 1436789 [details]
Brick Details page with brick down

1. The other two filters Utilization More Than and Utilization Less Than require following information regarding UX- 

a) The utilization will be compared on the basis of percentage or GBs? 
b) Since the filter will contain only the numbers with some validation, what validation and messages should be applied and displayed? 

2. Due to time constraint, basic filters were implemented.

3. `Failed Only` filter can be implemented, it was missed out.

For the Utilization More Than or Utilization Less Than, I'd suggest doing it based on percentage.  E.g. User wants to see all bricks greater than 80% for a volume.  We'll update the design to reflect this.

We've added a mockup to show how the Utilization More Than or Utilization Less Than filter will work -- see https://redhat.invisionapp.com/share/8QCOEVEY9#/298092970_Cluster_Details-Volumes-Bricks_Copy.

@Ju: We are using pfFilter[1] angular patternfly component for implementing filters across all the views in Tendrl. With respect to bugzilla issue https://bugzilla.redhat.com/show_bug.cgi?id=1559390, for implementing 'Utilization More Than" and "Utilization Less Than" filters, we need to integrate touchspin component[2] to pfFilter component and I don't see any support for it as per the current implementation. 

So, for the moment, we can either have a 
- integer type filter which will accept value from 0 to 100 or 
- select type filter containing options 10,20,30,40,50,60,70,8,90,100

What are your thoughts on this?

1. https://www.patternfly.org/angular-patternfly/#/api/patternfly.filters.component:pfFilter
2. https://www.npmjs.com/package/angular-touchspin

@negupta@redhat.com
Regarding getting the touchspin component into pfFilter in angular-patternfly, there's currently no UXD resources actively working working on angular-patternfly.

My guestion is for us to either integrate touchspin into the pfFilter component OR go with the integer type filter which will accept value from 0 to 100.  

Do you have a preference?

@ju As pfFilter doesn't provide any support to add any external html template or component(as per their doc), I feel it will be difficult to integrate touchspin into pfFilter component for now. Hence, I would prefer to implement utilization filters as integer type which will accept value from 0 to 100.

@julim@redhat.com @mcarrano@redhat.com As decided, we will go with integer type filter. Also, I have added "%" in the filter title for "Utilization More Than" and "Utilization Less Than" filters to indicate that the value entered are in percentage. Attaching the screenshot for the same.

Created attachment 1441032 [details]
Added % in the filter title of utilization filters

 * Filters `Utilization Less Than(%)` and `Utilization More Than(%)` are only on Brick Details page accessed from Volumes page. They are missing in filters on Brick Details accessed from Hosts page.
 * Filter `Utilization More Than(%)` does not take into consideration float values. For example when it is set to 10% then 10.30% is not selected (only values equal or greater than 11%).
 * Filters `Utilization Less Than(%)` and `Utilization More Than(%)` should have boundaries that don't allow user to set negative values and values greater than 100.
 * In design is percentage sign on the right side next to the number (https://redhat.invisionapp.com/share/8QCOEVEY9#/screens/298092970). In current implementation it is part of the label without a space.
--> ASSIGNED

Tested with:
tendrl-ansible-1.6.3-4.el7rhgs.noarch
tendrl-api-1.6.3-3.el7rhgs.noarch
tendrl-api-httpd-1.6.3-3.el7rhgs.noarch
tendrl-commons-1.6.3-6.el7rhgs.noarch
tendrl-grafana-plugins-1.6.3-4.el7rhgs.noarch
tendrl-grafana-selinux-1.5.4-2.el7rhgs.noarch
tendrl-monitoring-integration-1.6.3-4.el7rhgs.noarch
tendrl-node-agent-1.6.3-6.el7rhgs.noarch
tendrl-notifier-1.6.3-3.el7rhgs.noarch
tendrl-selinux-1.5.4-2.el7rhgs.noarch
tendrl-ui-1.6.3-3.el7rhgs.noarch

@fbalak@redhat.com 
Regarding the 4th point i.e percentage sign added as a label- 

since we have decided not to integrate touchspin component in pfFilter for now, UI can display percentage sign as a label only. Please read above conversations for more detail.

@mcarrano@redhat.com Please update the design.

I have found one small issue while verifying this issue. Hence, changing the state to Assigned again.

Looks ok. --> VERIFIED

Tested with:
tendrl-ansible-1.6.3-5.el7rhgs.noarch
tendrl-api-1.6.3-4.el7rhgs.noarch
tendrl-api-httpd-1.6.3-4.el7rhgs.noarch
tendrl-commons-1.6.3-9.el7rhgs.noarch
tendrl-grafana-plugins-1.6.3-7.el7rhgs.noarch
tendrl-grafana-selinux-1.5.4-2.el7rhgs.noarch
tendrl-monitoring-integration-1.6.3-7.el7rhgs.noarch
tendrl-node-agent-1.6.3-9.el7rhgs.noarch
tendrl-notifier-1.6.3-4.el7rhgs.noarch
tendrl-selinux-1.5.4-2.el7rhgs.noarch
tendrl-ui-1.6.3-8.el7rhgs.noarch

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2018:2616