Bug 1559472 - [CodeChange][RFE] add proxy mode to the daemon and obsolete common/proxy components
Summary: [CodeChange][RFE] add proxy mode to the daemon and obsolete common/proxy comp...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-imageio
Classification: oVirt
Component: RFEs
Version: 1.1.0
Hardware: Unspecified
OS: Unspecified
high
low
Target Milestone: ovirt-4.4.1
: ---
Assignee: Nir Soffer
QA Contact: Ilan Zuckerman
URL:
Whiteboard:
Depends On:
Blocks: 1554226
TreeView+ depends on / blocked
 
Reported: 2018-03-22 15:51 UTC by Daniel Erez
Modified: 2020-07-08 08:26 UTC (History)
4 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2020-07-08 08:26:12 UTC
oVirt Team: Storage
Embargoed:
amureini: ovirt-4.3?
sbonazzo: ovirt-4.5?
rule-engine: planning_ack?
rule-engine: devel_ack?
rule-engine: testing_ack?


Attachments (Terms of Use)

Description Daniel Erez 2018-03-22 15:51:39 UTC
Add a new mode to the daemon to act as a proxy, and integrate with engine instead of the current proxy. This will reduce complexity and avoid code duplication between current daemon and proxy components. I.e. after utilizing the daemon to behave as a proxy and merge common into daemon, both common and proxy could be obsoleted. As a result, we'll have a single imageio package.

Comment 1 Nir Soffer 2018-03-25 10:54:48 UTC
I think we don't need proxy mode, just have a "https:" url handler.

Engine will add this ticket to the ovirt-imgeio daemon running on the engine host:

    {
        "uuid": "ticket-id",
        "url": "https://daemon.address/",
        "ops: ["read", "write"],
        ...
    }

When send a request to the new proxy:

    PUT /images/ticket-id

The daemon https handler will send the same request to "daemon.address".

Comment 2 Sandro Bonazzola 2019-01-28 09:40:18 UTC
This bug has not been marked as blocker for oVirt 4.3.0.
Since we are releasing it tomorrow, January 29th, this bug has been re-targeted to 4.3.1.

Comment 3 Daniel Erez 2019-11-06 13:37:16 UTC
Proposing a higher priority as this change is needed in order to support engine on el8 (as imageio-proxy is not yet suitable for py3).
@Tal - should we target it as 4.4 or 4.5?

Comment 4 Tal Nisan 2019-11-11 11:50:36 UTC
(In reply to Daniel Erez from comment #3)
> Proposing a higher priority as this change is needed in order to support
> engine on el8 (as imageio-proxy is not yet suitable for py3).
> @Tal - should we target it as 4.4 or 4.5?

4.4 would do

Comment 5 Nir Soffer 2020-04-26 00:45:58 UTC
Finished in ovirt-imageio 2.0.5.

Comment 6 Ilan Zuckerman 2020-06-01 07:44:56 UTC
Nir, Please provide verification steps.

Comment 9 Nir Soffer 2020-06-01 21:24:26 UTC
Verification: check that upload and download images from UI works in 4.4.

Comment 10 Ilan Zuckerman 2020-06-02 08:24:57 UTC
Verified according steps from comment #8
on rhv-4.4.1-2

Comment 11 Sandro Bonazzola 2020-07-08 08:26:12 UTC
This bugzilla is included in oVirt 4.4.1 release, published on July 8th 2020.

Since the problem described in this bug report should be resolved in oVirt 4.4.1 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.


Note You need to log in before you can comment on or make changes to this bug.