Bug 1559534

Created attachment 1411810 [details]
Patch to fix problem

Description of problem:


Version-Release number of selected component (if applicable):
2.2.9 -> Master/Tip


How reproducible:
Always

Steps to Reproduce:
1.Have machine with secondary ip's assign to interfaces
E.G.

cat /etc/sysconfig/network-scripts/ifcfg-ens33
DEVICE=ens33
BOOTPROTO=none
DEFROUTE=yes
NAME=ens33
ONBOOT=yes
TYPE=Ethernet
IPADDR=10.10.10.4
PREFIX=28
GATEWAY=10.10.10.2
NM_CONTROLLED=no
[devel@tester ~]$ cat /etc/sysconfig/network-scripts/ifcfg-ens33:0

DEVICE=ens33:0
BOOTPROTO=static
ONBOOT=yes
IPADDR=10.10.10.5
NETMASK=255.255.255.240
NM_CONTROLLED=no

2. Run `sudo hosted-engine --deploy`


Actual results:
[ INFO  ] TASK [Get all active network interfaces]
[ ERROR ] fatal: [localhost]: FAILED! => {"msg": "The conditional check '( ( item != 'lo' ) and ( hostvars[inventory_hostname]['ansible_' + item]['active'] ) and ( hostvars[inventory_hostname]['ansible_' + item]['type'] != 'bridge' ) and ( ( hostvars[inventory_hostname]['ansible_' + item]['ipv4'] is defined ) or ( hostvars[inventory_hostname]['ansible_' + item]['ipv6'] is defined ) or ( ( hostvars[inventory_hostname]['ansible_' + item]['type'] == 'bonding' ) and ( hostvars[inventory_hostname]['ansible_' + item]['slaves'][0] is defined ) and ( hostvars[inventory_hostname]['ansible_' + item]['mode'] in acceptable_bond_modes ) ) ) )' failed. The error was: error while evaluating conditional (( ( item != 'lo' ) and ( hostvars[inventory_hostname]['ansible_' + item]['active'] ) and ( hostvars[inventory_hostname]['ansible_' + item]['type'] != 'bridge' ) and ( ( hostvars[inventory_hostname]['ansible_' + item]['ipv4'] is defined ) or ( hostvars[inventory_hostname]['ansible_' + item]['ipv6'] is defined ) or ( ( hostvars[inventory_hostname]['ansible_' + item]['type'] == 'bonding' ) and ( hostvars[inventory_hostname]['ansible_' + item]['slaves'][0] is defined ) and ( hostvars[inventory_hostname]['ansible_' + item]['mode'] in acceptable_bond_modes ) ) ) )): 'dict object' has no attribute 'active'\n\nThe error appears to have been in '/usr/share/ovirt-hosted-engine-setup/ansible/get_network_interfaces.yml': line 6, column 5, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n  tasks:\n  - name: Get all active network interfaces\n    ^ here\n"}
[ ERROR ] Failed to execute stage 'Environment customization': Failed executing ansible-playbook


Expected results:
Installation presents nic options as per normal:
[ INFO  ] TASK [filter bonds with bad naming]
          Please indicate a nic to set ovirtmgmt bridge on: (dummy_0, ens33) [dummy_0]: 

Additional info:
The way ansible returns networks facts.  IT seems secondary interfaces can be populated as such:

"ansible_ens33_0": {
            "ipv4_secondaries": [
                {
                    "address": "10.10.10.5", 
                    "broadcast": "10.10.10.15", 
                    "netmask": "255.255.255.240", 
                    "network": "10.10.10.0"
                }
            ]
        }, 

which breaks the reference to "active"


PATCH to fix included inline:
diff --git a/src/ansible/get_network_interfaces.yml b/src/ansible/get_network_interfaces.yml
index 593a73b..1b1f12d 100644
--- a/src/ansible/get_network_interfaces.yml
+++ b/src/ansible/get_network_interfaces.yml
@@ -23,7 +23,7 @@
         ) and (
           'ansible_' + MGMT_NETWORK not in hostvars[inventory_hostname]
         ) and (
-          hostvars[inventory_hostname]['ansible_' + item]['active']
+          active in hostvars[inventory_hostname]['ansible_' + item] and hostvars[inventory_hostname]['ansible_' + item]['active']
         ) and (
           hostvars[inventory_hostname]['ansible_' + item]['type'] != 'bridge'
         ) and (