Bug 1560497 - regression should trigger when we change behaviour of product
Summary: regression should trigger when we change behaviour of product
Keywords:
Status: CLOSED DUPLICATE of bug 1560393
Alias: None
Product: GlusterFS
Classification: Community
Component: project-infrastructure
Version: mainline
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: bugs@gluster.org
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-03-26 10:43 UTC by Sanju
Modified: 2018-03-26 13:48 UTC (History)
4 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2018-03-26 13:48:50 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Sanju 2018-03-26 10:43:14 UTC
Description of problem:
Currently regression is skipping the tests for changes in some ignored files and saying regression is success. Some of these files can change the behaviour of the product and some test cases might be written considering the old values in those files. So regression needs to trigger the test cases for changes in the files which can change the behaviour of the product.

Here, is a similar case: 

This patch (https://review.gluster.org/#/c/19744/) changed the network.inode-lru-limit value from 50000 to 200000. Regression is success saying "Skipped tests for change that only modifies ignored files". This caused tests/basic/md-cache/bug-1418249.t test to fail in master because it was expecting the old value.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Nigel Babu 2018-03-26 11:58:55 UTC
This is handled by the .testignore file in the root of the repo. You can send a patch to remove those two files from .testignore in the root of the repo.

Comment 2 Amar Tumballi 2018-03-26 13:46:04 UTC
Sorry, used another bug id for this: https://review.gluster.org/19775  fixes the issue now

Comment 3 Nigel Babu 2018-03-26 13:48:50 UTC

*** This bug has been marked as a duplicate of bug 1560393 ***


Note You need to log in before you can comment on or make changes to this bug.