Bug 1560498 - Review Request: golang-github-buger-jsonparser - Alternative JSON parser for Go that does not require schema (so far fastest)
Summary: Review Request: golang-github-buger-jsonparser - Alternative JSON parser for ...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-03-26 10:44 UTC by Dominik 'Rathann' Mierzejewski
Modified: 2018-03-28 19:52 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-03-28 19:52:36 UTC
Type: ---
Embargoed:
zebob.m: fedora-review+


Attachments (Terms of Use)

Description Dominik 'Rathann' Mierzejewski 2018-03-26 10:44:03 UTC
Spec URL: https://rathann.fedorapeople.org/review/golang-github-buger-jsonparser/golang-github-buger-jsonparser.spec
SRPM URL: https://rathann.fedorapeople.org/review/golang-github-buger-jsonparser/golang-github-buger-jsonparser-0-0.1.20180322git2cac668.20180322git2cac668.fc27.src.rpm
Description:
Alternative JSON parser for Go (so far fastest)

It does not require you to know the structure of the payload (eg. create
structs), and allows accessing fields by providing the path to them. It is up to
10 times faster than standard encoding/json package (depending on payload size
and usage), allocates no memory.

Fedora Account System Username: rathann

Comment 1 Dominik 'Rathann' Mierzejewski 2018-03-26 10:46:35 UTC
Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=25985675

Comment 2 Robert-André Mauchin 🐧 2018-03-27 13:14:33 UTC
 - Forge URL is only needed when goipath is "exotic", otherwise gometa can detect it directly from goipath.

%global forgeurl https://github.com/buger/jsonparser/

 - I don't think this is necessary:

BuildArch: noarch
ExclusiveArch: %{go_arches} noarch

  ExclusiveArch is automatically set by gometa, and noarch is only needed by the devel package.


 - Latest version packaged
 - License ok
 - Builds in Mock
 - No rpmlint errors
 - Conforms to the Packaging Guidelines

Package approved.

Comment 3 Gwyn Ciesla 2018-03-27 21:43:01 UTC
(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-buger-jsonparser

Comment 4 Dominik 'Rathann' Mierzejewski 2018-03-28 19:52:36 UTC
I fixed both comments and built for rawhide. Thanks for the review, Robert.


Note You need to log in before you can comment on or make changes to this bug.