Bug 1560546 - ogdi: Partial Fedora build flags injection
Summary: ogdi: Partial Fedora build flags injection
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: ogdi
Version: 28
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Dan Horák
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: Fedora28BuildFlags
TreeView+ depends on / blocked
 
Reported: 2018-03-26 12:26 UTC by Florian Weimer
Modified: 2018-04-10 22:56 UTC (History)
1 user (show)

Fixed In Version: ogdi-3.2.1-1.fc28
Clone Of:
Environment:
Last Closed: 2018-04-10 22:56:17 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Florian Weimer 2018-03-26 12:26:13 UTC
Various binaries in ogdi-3.2.0-5.fc28.x86_64 have not been linked with the standard Fedora linker flags (LDFLAGS) from redhat-rpm-config.

For example:

gcc -shared  -g  -g -O2 -pipe -Wall -Werror=format-security  -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -mcet -fcf-protection -fPIC -DPIC -DDONT_TD_VOID -DUSE_TERMIO  -Wall -DUNIX=1 -I/usr/include/tirpc -o /builddir/build/BUILD/ogdi-3.2.0/bin/Linux/libdtcanada.so nadconv.o dtcanada.o  

gcc -g  -g -O2 -pipe -Wall -Werror=format-security  -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -mcet -fcf-protection -fPIC -DPIC -DDONT_TD_VOID -DUSE_TERMIO  -Wall -DUNIX=1 -I/usr/include/tirpc -o /builddir/build/BUILD/ogdi-3.2.0/bin/Linux/gltpd asyncsvr.o ecs_sif.o ecs_svc.o -L/builddir/build/BUILD/ogdi-3.2.0/bin/Linux -logdi -lz -ltirpc -lproj  -lm -lc

CFLAGS is there, but LDFLAGS is missing.  It may be possible to fix this at the RPM spec file level by stuffing LDFLAGS into CFLAGS, too.

Comment 1 Fedora Update System 2018-04-04 12:16:13 UTC
ogdi-3.2.1-1.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-92186e46e8

Comment 2 Fedora Update System 2018-04-04 18:36:55 UTC
ogdi-3.2.1-1.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-92186e46e8

Comment 3 Fedora Update System 2018-04-10 22:56:17 UTC
ogdi-3.2.1-1.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.