Bug 1560561 - systemd service file enhancements
Summary: systemd service file enhancements
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: core
Version: mainline
Hardware: Unspecified
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Vijay Bellur
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-03-26 12:47 UTC by Patrick Matthäi
Modified: 2019-03-25 16:30 UTC (History)
2 users (show)

Fixed In Version: glusterfs-6.0
Clone Of:
Environment:
Last Closed: 2019-03-25 16:30:19 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)
Add documentation key and fix obsolete target (1.07 KB, text/plain)
2018-03-26 12:47 UTC, Patrick Matthäi
no flags Details
Patch for 4.1.2 (1.12 KB, text/plain)
2018-07-26 12:14 UTC, Patrick Matthäi
no flags Details


Links
System ID Private Priority Status Summary Last Updated
Gluster.org Gerrit 21723 0 None Merged extras/systemd: Remove socket activated syslog.target and add documentation keys 2019-01-11 07:30:46 UTC

Description Patrick Matthäi 2018-03-26 12:47:05 UTC
Created attachment 1413104 [details]
Add documentation key and fix obsolete target

Hello,

I have attached a patch, which adds the documentation key to the .service units.
It also fixes a dependency on the obsolete syslog.target. Debian writes about it:

=> The systemd service file refers to an obsolete target.
=> Some targets are obsolete by now, e.g. syslog.target or dbus.target. For
=> example, declaring After=syslog.target is unnecessary by now because
=> syslog is socket-activated and will therefore be started when needed.

Comment 1 Shyamsundar 2018-06-20 18:27:29 UTC
This bug reported is against a version of Gluster that is no longer maintained (or has been EOL'd). See https://www.gluster.org/release-schedule/ for the versions currently maintained.

As a result this bug is being closed.

If the bug persists on a maintained version of gluster or against the mainline gluster repository, request that it be reopened and the Version field be marked appropriately.

Comment 2 Shyamsundar 2018-06-20 18:27:52 UTC
This bug reported is against a version of Gluster that is no longer maintained
(or has been EOL'd). See https://www.gluster.org/release-schedule/ for the
versions currently maintained.

As a result this bug is being closed.

If the bug persists on a maintained version of gluster or against the mainline
gluster repository, request that it be reopened and the Version field be marked
appropriately.

Comment 3 Patrick Matthäi 2018-07-26 12:13:42 UTC
Still exists.... Autoclosing bugs nobody had an eye on it (with patches!) is a nobrainer..

Attached enhanced patch for 4.1.2.....

Comment 4 Patrick Matthäi 2018-07-26 12:14:11 UTC
Created attachment 1470751 [details]
Patch for 4.1.2

Comment 5 Worker Ant 2018-11-27 06:22:53 UTC
REVIEW: https://review.gluster.org/21723 (extras/systemd: Remove socket activated syslog.target and add documentation keys) posted (#1) for review on master by Vijay Bellur

Comment 6 Worker Ant 2019-01-11 07:30:46 UTC
REVIEW: https://review.gluster.org/21723 (extras/systemd: Remove socket activated syslog.target and add documentation keys) posted (#2) for review on master by Amar Tumballi

Comment 7 Shyamsundar 2019-03-25 16:30:19 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-6.0, please open a new bug report.

glusterfs-6.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] https://lists.gluster.org/pipermail/announce/2019-March/000120.html
[2] https://www.gluster.org/pipermail/gluster-users/


Note You need to log in before you can comment on or make changes to this bug.