Bug 1560661 - Binary build with --from-file not working
Summary: Binary build with --from-file not working
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Build
Version: 3.10.0
Hardware: Unspecified
OS: Unspecified
unspecified
urgent
Target Milestone: ---
: 3.10.0
Assignee: Ben Parees
QA Contact: Wenjing Zheng
URL:
Whiteboard:
Depends On: 1560608
Blocks: 1560659
TreeView+ depends on / blocked
 
Reported: 2018-03-26 16:41 UTC by Ben Parees
Modified: 2021-06-10 15:31 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Cause: Build pods use multiple containers. Binary builds need to specify which container to stream content into, and for custom builds the name of the container is different from non-custom builds. Consequence: When streaming binary content into a custom build, the expected container (git-clone) does not exist and the build fails. Fix: The logic for streaming binary content into a custom build pod will be changed to reference the correct container name (custom-build) Result: Binary content will successfully stream into the custom build container.
Clone Of: 1560608
Environment:
Last Closed: 2018-07-30 19:11:31 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2018:1816 0 None None None 2018-07-30 19:12:11 UTC

Comment 1 Ben Parees 2018-03-26 17:53:04 UTC 
PR: https://github.com/openshift/origin/pull/19102
Comment 2 openshift-github-bot 2018-03-27 16:45:10 UTC 
Commit pushed to master at https://github.com/openshift/origin

https://github.com/openshift/origin/commit/1753e9c03fdf5507bf815b0b198588915fa7f389
setup binary input for custom builds properly

bug 1560661

https://bugzilla.redhat.com/show_bug.cgi?id=1560661
Comment 3 Wenjing Zheng 2018-04-19 07:41:57 UTC 
Verified with below steps on v3.10.0-0.22.0:
1. Edit custom builder image Dockerfile like below:
#CMD ["/tmp/build.sh"]
ENTRYPOINT tar -xf -
2. docker build . -t custom-builder
3. Create a custom build with above customized builder image
4. git clone https://github.com/openshift/ruby-hello-world; tar -cf ruby-hello-world.tar.gz ruby-hello-world
5. $ oc start-build ruby-sample-build --from-file=ruby-hello-world.tar.gz --follow --wait  --loglevel=5
Uploading file "ruby-hello-world.tar.gz" as binary input for the build ...
build "ruby-sample-build-2" started
Comment 5 errata-xmlrpc 2018-07-30 19:11:31 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2018:1816
Note You need to log in before you can comment on or make changes to this bug.