Bug 1560908 - perl-Git-Repository-1.321-2.fc29 FTBFS: Failed test '... expected error message': doesn't match '(?^:^fatal: Not a git repository)'
Summary: perl-Git-Repository-1.321-2.fc29 FTBFS: Failed test '... expected error messa...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: perl-Git-Repository
Version: 28
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Jan Pazdziora (Red Hat)
QA Contact: Fedora Extras Quality Assurance
URL: https://apps.fedoraproject.org/kosche...
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-03-27 09:03 UTC by Petr Pisar
Modified: 2018-04-27 04:05 UTC (History)
3 users (show)

Fixed In Version: perl-Git-Repository-1.321-3.fc28
Clone Of:
Environment:
Last Closed: 2018-04-27 04:05:51 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Petr Pisar 2018-03-27 09:03:16 UTC
perl-Git-Repository-1.321-2.fc29 fails to build in F29 because a test fails:

t/07-version.t ............. ok

#   Failed test '... expected error message'
#   at t/10-new_fail.t line 51.
#                   'fatal: not a git repository (or any parent up to mount point /)
# Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set). at t/10-new_fail.t line 48.
# '
#     doesn't match '(?^:^fatal: Not a git repository)'
# Looks like you failed 1 test of 12.
t/10-new_fail.t ............
Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/12 subtests

This is very probably caused by upgrading git from 2.16.2-1.fc28 to
2.17.0-0.1.rc1.fc29.

Comment 1 Jan Pazdziora (Red Hat) 2018-03-27 20:12:25 UTC
I've filed https://github.com/book/Git-Repository/pull/18 with upstream now. I shall see if the upstream author is happy to incorporate it and make new release. If not, I'll include the patch in the .src.rpm.

Comment 2 Jan Pazdziora (Red Hat) 2018-04-03 08:42:13 UTC
Built perl-Git-Repository-1.321-3.fc29 with the patch:
https://koji.fedoraproject.org/koji/buildinfo?buildID=1064876

Comment 3 Petr Pisar 2018-04-17 14:05:53 UTC
And git-2.17.0 is in F28 now <https://apps.fedoraproject.org/koschei/package/perl-Git-Repository?collection=f28>. Please merge this fix to F28.

Comment 4 Fedora Update System 2018-04-17 14:46:09 UTC
perl-Git-Repository-1.321-3.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-63db4756a6

Comment 5 Fedora Update System 2018-04-17 18:09:27 UTC
perl-Git-Repository-1.321-3.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-63db4756a6

Comment 6 Fedora Update System 2018-04-27 04:05:51 UTC
perl-Git-Repository-1.321-3.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.