Bug 1560978 - hammer host list --thin removed in Red Hat Satellite 6.3
Summary: hammer host list --thin removed in Red Hat Satellite 6.3
Status: VERIFIED
Alias: None
Product: Red Hat Satellite 6
Classification: Red Hat
Component: Hammer   
(Show other bugs)
Version: 6.3.0
Hardware: x86_64
OS: Linux
high
high vote
Target Milestone: 6.5.0
Assignee: satellite6-bugs
QA Contact: Peter Ondrejka
URL:
Whiteboard:
Keywords: Regression, Triaged
Depends On:
Blocks: 1644750 1644751
TreeView+ depends on / blocked
 
Reported: 2018-03-27 12:02 UTC by Simon Reber
Modified: 2019-01-01 03:03 UTC (History)
17 users (show)

Fixed In Version: tfm-rubygem-hammer_cli_foreman-0.15.1
Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1644750 1644751 1661289 (view as bug list)
Environment:
Last Closed:
Type: Bug
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)


External Trackers
Tracker ID Priority Status Summary Last Updated
Foreman Issue Tracker 25349 None None None 2018-10-31 11:27 UTC
Red Hat Bugzilla 1461194 None CLOSED [RFE] API to fetch list of hosts without full host details 2019-03-18 04:35 UTC

Internal Trackers: 1461194

Description Simon Reber 2018-03-27 12:02:59 UTC
Description of problem:

`hammer host list --thin` does no longer work as `--thin` option was removed from `hammer` in Red Hat Satellite 6.3 (as per https://bugzilla.redhat.com/show_bug.cgi?id=1503586).

This option is heavily used and required by customers, to generate fast list of hosts in case not all details are required.

See https://bugzilla.redhat.com/show_bug.cgi?id=1503586#c7 for details

The API call `thin` is still there and works.

As this was working in Red Hat Satellite 6.2 (and because it's available via API) we are requesting to have this back.

Also, when checking https://bugzilla.redhat.com/show_bug.cgi?id=1503586 it's odd that `--thin` was removed as actually `--include` was questioned.

Version-Release number of selected component (if applicable):

 - tfm-rubygem-hammer_cli-0.11.0.1-1.el7sat.noarch

How reproducible:

 - Always

Steps to Reproduce:
1. [root@satellite63 ~]# rpm -q satellite
   satellite-6.3.0.1-1.el7sat.noarch
   [root@satellite63 ~]# hammer -u admin -p <pwd> host list --help | grep thin
   [root@satellite63 ~]#

2. [root@dhcp-144-209 ~]# rpm -q satellite
   satellite-6.2.14-4.0.el7sat.noarch
   [root@dhcp-144-209 ~]# hammer -u admin -p <pwd> host list --help | grep thin
    --thin THIN                       Only list ID and name of hosts
   [root@dhcp-144-209 ~]#

Actual results:

[root@satellite63 ~]# hammer -u admin -p <pwd> host list --help | grep thin
[root@satellite63 ~]#

Expected results:

[root@dhcp-144-209 ~]# hammer -u admin -p <pwd> host list --help | grep thin
--thin THIN                       Only list ID and name of hosts

Additional info:

Comment 3 Brad Buckingham 2018-04-02 17:20:13 UTC
Based upon https://bugzilla.redhat.com/show_bug.cgi?id=1503586#c7, it appears that --thin was included in earlier 6.3 builds.

Tomas, do you know if this may have been purposely removed?

Comment 4 Tomas Strachota 2018-04-03 07:41:27 UTC
I went through the BZ you're mentioning and it seems that --thin was removed based on inaccurate interpretation of the BZ. The first comment mentions that --include and --thin has no effect and there fore it should be removed. One of the later comments showed that --thin has actually significant performance impact but leaves some of the table columns blank.

I believe that the correct fix is:
- remove --include from host/hostgroup list (already done)
- keep --thin for host list (needs to be added back)
- extra points for hiding fields other than 'id' and 'name' when --thin is passed

Comment 17 Ivan Necas 2018-10-31 11:26:53 UTC
Created redmine issue https://projects.theforeman.org/issues/25349 from this bug

Comment 21 Peter Ondrejka 2018-11-14 08:56:31 UTC
Verified on Sat 6.5 snap 5, I find it a bit annoying you have to add boolean parameter to it (as if someone ever used '--thin no'), but since it was already used and loved as it was, it's probably better to keep the form intact


Note You need to log in before you can comment on or make changes to this bug.