Description of problem: Vdsm currently replaces whole sections of XML to perform host-specific changes. This means we override data from Engine, but Engine is the ultimate source of truth. Vdsm should minimize those changes. For hooks, there is no real choice but replace the XML snippet the hooks returned, so this still needs to be done. For device-specific changes (e.g. NICs, drives, leases), Vdsm should strive to minimize the changes, modifying only the attributes (e.g. drive path, lease offsets) and not replacing the whole XML. This will make much, much simpler to add features in Engine. This is the tracker bug
this change is completely transparent for the users -everything should work as before, or even better, thus doesn't require doc_text
Verified on: ovirt-engine-4.2.3.3-0.1.el7.noarch vdsm-4.20.27-1.el7ev.x86_64 libvirt-3.9.0-14.el7_5.3.x86_64 Steps of verification: Most of the normal flows are checked within the automation. Some infrequent combinations that were tested manually: 1. hot-plug disk, create snapshot of it steps: a. create a VM. b. start the VM. c. hot-plug disk. d. create snapshot of the VM. 2. hot-unplug disk, migrate the VM steps: a. create a VM. b. start the VM. c. hot-unplug disk. d. migrate the VM. 3. hot-plug NIC, suspend VM, resume VM steps: a. create a VM. b. start the VM. c. hot-plug NIC. d. suspend the VM. e. resume the VM.
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHEA-2018:1489
BZ<2>Jira Resync