Bugzilla will be upgraded to version 5.0. The upgrade date is tentatively scheduled for 2 December 2018, pending final testing and feedback.
Bug 1561131 - Re-deployment with conf-changes is fails due to "ValueError: The Parameter (DeployIdentifier) was not provided.
Re-deployment with conf-changes is fails due to "ValueError: The Parameter (D...
Status: CLOSED ERRATA
Product: Red Hat OpenStack
Classification: Red Hat
Component: python-tripleoclient (Show other bugs)
13.0 (Queens)
x86_64 Linux
high Severity high
: z2
: 13.0 (Queens)
Assigned To: RHOS Maint
Gurenko Alex
: Triaged, ZStream
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2018-03-27 12:44 EDT by Artem Hrechanychenko
Modified: 2018-08-29 12:46 EDT (History)
14 users (show)

See Also:
Fixed In Version: python-tripleoclient-9.2.3-2.el7ost
Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2018-08-29 12:35:26 EDT
Type: Bug
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)


External Trackers
Tracker ID Priority Status Summary Last Updated
Launchpad 1759326 None None None 2018-03-28 00:06 EDT
OpenStack gerrit 583079 None stable/queens: MERGED python-tripleoclient: DeployIdentifier should be provided for any parameter actions (I26cc11895a376788d8aad41727676bec73... 2018-07-18 10:48 EDT
Red Hat Product Errata RHBA-2018:2574 None None None 2018-08-29 12:36 EDT

  None (edit)
Description Artem Hrechanychenko 2018-03-27 12:44:47 EDT
Description of problem:
Re-deployment of OC with configuration changes was fail with next message:

http://paste.openstack.org/show/715430/

u'message': {u'result': u'Failure caused by error in tasks: set_get_tempurl\n\n set_get_tempurl [task_ex_id=a6be7858-2795-48c2-a8e8-8ad4ab4e6c81] -> Error validating environment for plan overcloud: ERROR: Internal Error\n [action_ex_id=66be174f-2a1d-4880-aec1-613cc09de17a, idx=0]: Error validating environment for plan overcloud: ERROR: Internal Error\n',
              u'swift_rings_container': u'overcloud-swift-rings',
              u'swift_rings_tar': u'swift-rings.tar.gz'},

from mistral logs -
error - ValueError: The Parameter (DeployIdentifier) was not provided.

empty DeployIdentifier: '' as a W/A

https://rhos-ci-staging-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/view/DF%20Current%20release/job/DFG-df-13-deployment-7.5-virthost-3cont_2comp_3ceph-yes_UC_SSL-yes_OC_SSL-ceph-ipv4-vxlan-conf_changes-RHELOSP-31868/8/

Version-Release number of selected component (if applicable):
openstack-tripleo-heat-templates-8.0.0-0.20180304031148.el7ost.noarch


How reproducible:
Always

Steps to Reproduce:
1.Deploy OSP13 
2. create [stack@undercloud-0 ~]$ cat /home/stack/templates/post_config.yaml
resource_registry:
  OS::TripleO::NodeExtraConfigPost: /home/stack/templates/nameserver.yaml

parameter_defaults:
  nameserver_ip1: 10.11.5.19
  nameserver_ip2: 10.10.160.2
  nameserver_ip3: 10.5.30.160

3.add that file to oc deploy command and re-run OC deployment

Actual results:
u'message': {u'result': u'Failure caused by error in tasks: set_get_tempurl\n\n set_get_tempurl [task_ex_id=a6be7858-2795-48c2-a8e8-8ad4ab4e6c81] -> Error validating environment for plan overcloud: ERROR: Internal Error\n [action_ex_id=66be174f-2a1d-4880-aec1-613cc09de17a, idx=0]: Error validating environment for plan overcloud: ERROR: Internal Error\n',
              u'swift_rings_container': u'overcloud-swift-rings',
              u'swift_rings_tar': u'swift-rings.tar.gz'},

STACK status - CREATE_COMPLETE

http://pastebin.test.redhat.com/569269

Expected results:
Stack status UPDATE_COMPLETE

Additional info:
Comment 2 Emilien Macchi 2018-03-28 00:06:32 EDT
Like I said in the bug report, I'm not sure this is a valid bug. You need to update your template with empty DeployIdentifier in the case of a re-deploy.
Once thing I haven't figured yet is why DeployIdentifier is not taken from the deploy-steps.j2 in THT or from overcloud.j2.yaml which both have correct default (to '').
Comment 3 Steve Baker 2018-04-02 16:50:44 EDT
Do you have a feel for if this is a real bug yet?
Comment 4 Emilien Macchi 2018-04-02 17:00:48 EDT
We need to look why DeployIdentifier isn't set to '' by default in the deployment but it's documented in extraconfig/post_deploy/example_run_on_update.yaml file in THT.

I think yes, it's a bug and we need to lookup how default is set.
Comment 9 Keigo Noha 2018-07-13 00:52:54 EDT
Hi,

Upstream already merged the patch into the tree. 
This bugzilla affected to the process in 4.4. Post-Configuration: Customizing All Overcloud Roles in https://access.redhat.com/documentation/en-us/red_hat_openstack_platform/13/html-single/advanced_overcloud_customization/#sect-Customizing_Overcloud_PostConfiguration_All.

This issue should be fixed soon.

Best Regards,
Keigo Noha
Comment 10 Keigo Noha 2018-07-13 02:40:37 EDT
Hi Emilien,

The patch in the upstream works fine in my reproducer.

Best Regards,
Keigo Noha
Comment 21 Gurenko Alex 2018-08-01 04:06:01 EDT
Verified on puddle 2018-07-30.2

 Successfully updated stack after adding nameserver yaml and updating parameter_deafults with namesserver_ip. /etc/resolv.conf also updated successfully.
Comment 22 Joanne O'Flynn 2018-08-15 04:07:09 EDT
This bug is marked for inclusion in the errata but does not currently contain draft documentation text. To ensure the timely release of this advisory please provide draft documentation text for this bug as soon as possible.

If you do not think this bug requires errata documentation, set the requires_doc_text flag to "-".


To add draft documentation text:

* Select the documentation type from the "Doc Type" drop down field.

* A template will be provided in the "Doc Text" field based on the "Doc Type" value selected. Enter draft text in the "Doc Text" field.
Comment 24 errata-xmlrpc 2018-08-29 12:35:26 EDT
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2018:2574

Note You need to log in before you can comment on or make changes to this bug.