Bug 1561413 - [RFE] Remove option should be grayed out for delete protected VMs
Summary: [RFE] Remove option should be grayed out for delete protected VMs
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: Frontend.WebAdmin
Version: future
Hardware: All
OS: All
unspecified
medium
Target Milestone: ovirt-4.3.0
: 4.3.0
Assignee: Ryan Barry
QA Contact: samuel macko
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-03-28 09:43 UTC by Nicolas Ecarnot
Modified: 2019-02-13 07:43 UTC (History)
4 users (show)

Fixed In Version: ovirt-engine-4.3.0_alpha
Doc Type: Enhancement
Doc Text:
In the current release of the Red Hat Virtualization Manager, the "Remove" option is disabled if a virtual machine is delete-protected.
Clone Of:
Environment:
Last Closed: 2019-02-13 07:43:41 UTC
oVirt Team: Virt
Embargoed:
rbarry: ovirt-4.3?
rule-engine: planning_ack?
rbarry: devel_ack+
lsvaty: testing_ack+


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 95117 0 master MERGED frontend: Disable the "Remove" button if VM is delete protected 2018-11-16 00:00:11 UTC

Description Nicolas Ecarnot 2018-03-28 09:43:46 UTC
Description of problem:
In the web admin GUI, letting the user access the remove option of a delete protected VMs is leading to a pointless failure.

Version-Release number of selected component (if applicable):
All

How reproducible:
always

Steps to Reproduce:
1. Check the delete protection checkbox of a VM
2. Try to remove it
3. A popup appears and the VM is not deleted.

Actual results:
Time is lost.

Expected results:
As lots of other options in these menus, this one should be grayed out when pointless. For the sake of homogeneity, this peculiar action should as well be disabled because it is leading to no action.

Additional info:
I understand that the popup is adding an information about the reason why it fails. But :
- the other options which are grayed out when useless show no such hint (trying to stop a stopped VM, and so on...)
- there must be a faster way to show the user why this option is grayed out. For instance, the grayed out option could change from "Remove" to "Remove - Protected".

Comment 1 Greg Sheremeta 2018-03-29 17:58:43 UTC
oVirt has spotty support for disabling things. I'm not sure this one is possible with current architecture. @virt team

Comment 2 samuel macko 2019-02-12 13:43:09 UTC
Verified on ovirt-engine-4.3.0.4-0.1.el7.noarch.
Verified by following the reproducer.

Comment 3 Sandro Bonazzola 2019-02-13 07:43:41 UTC
This bugzilla is included in oVirt 4.3.0 release, published on February 4th 2019.

Since the problem described in this bug report should be
resolved in oVirt 4.3.0 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.


Note You need to log in before you can comment on or make changes to this bug.