Bug 1561560 - Review Request: golang-github-google-cmp - Package for comparing Go values in tests
Summary: Review Request: golang-github-google-cmp - Package for comparing Go values in...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jared Smith
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-03-28 14:24 UTC by Robert-André Mauchin 🐧
Modified: 2018-06-02 21:08 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-05-05 20:31:06 UTC
Type: ---
Embargoed:
jsmith.fedora: fedora-review+


Attachments (Terms of Use)

Description Robert-André Mauchin 🐧 2018-03-28 14:24:11 UTC
Spec URL: https://copr-be.cloud.fedoraproject.org/results/eclipseo/rclone/fedora-rawhide-x86_64/00730584-golang-github-google-cmp/golang-github-google-cmp.spec
SRPM URL: https://copr-be.cloud.fedoraproject.org/results/eclipseo/rclone/fedora-rawhide-x86_64/00730584-golang-github-google-cmp/golang-github-google-cmp-0.2.0-1.fc29.src.rpm

Description:
This package is intended to be a more powerful and safer alternative to 
reflect.DeepEqual for comparing whether two values are semantically equal.

The primary features of cmp are:

 - When the default behavior of equality does not suit the needs of the 
 test, custom equality functions can override the equality operation. 
 For example, an equality function may report floats as equal so long as 
 they are within some tolerance of each other.

 - Types that have an Equal method may use that method to determine equality. 
 This allows package authors to determine the equality operation for the types 
 that they define.

 - If no custom equality functions are used and no Equal method is defined, 
 equality is determined by recursively comparing the primitive kinds on both 
 values, much like reflect.DeepEqual. Unlike reflect.DeepEqual, unexported 
 fields are not compared by default; they result in panics unless suppressed 
 by using an Ignore option (see cmpopts.IgnoreUnexported) or explicitly 
 compared using the AllowUnexported option.

Fedora Account System Username: eclipseo

Comment 1 Jared Smith 2018-04-13 20:22:08 UTC
This package conforms to the packaging guidelines, and is APPROVED.

Comment 2 Gwyn Ciesla 2018-04-17 15:03:34 UTC
(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-google-cmp

Comment 3 Fedora Update System 2018-04-21 15:22:13 UTC
golang-github-google-cmp-0.2.0-1.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-8b42d9bc93

Comment 4 Fedora Update System 2018-04-23 22:51:16 UTC
golang-github-google-cmp-0.2.0-1.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-8b42d9bc93

Comment 5 Fedora Update System 2018-05-05 20:31:06 UTC
golang-github-google-cmp-0.2.0-1.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report.

Comment 6 Fedora Update System 2018-05-24 19:30:47 UTC
golang-github-google-cmp-0.2.0-1.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-04a478b03b

Comment 7 Fedora Update System 2018-05-25 15:43:23 UTC
golang-github-google-cmp-0.2.0-1.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-04a478b03b

Comment 8 Fedora Update System 2018-06-02 21:08:11 UTC
golang-github-google-cmp-0.2.0-1.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.