Bug 1561927 - engine.log - timezone handling broken for utc
Summary: engine.log - timezone handling broken for utc
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine-metrics
Classification: oVirt
Component: Generic
Version: 1.0.0
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: ovirt-4.2.3
: ---
Assignee: Shirly Radco
QA Contact: Lukas Svaty
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-03-29 08:12 UTC by Shirly Radco
Modified: 2018-05-10 06:28 UTC (History)
4 users (show)

Fixed In Version: ovirt-engine-metrics-1.1.4-1.el7ev
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-05-10 06:28:46 UTC
oVirt Team: Metrics
Embargoed:
rule-engine: ovirt-4.2+


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 89590 0 master MERGED fix timezone for logs parsing 2018-04-04 14:34:25 UTC

Description Shirly Radco 2018-03-29 08:12:43 UTC
Description of problem:
Timestamp  is missing timezone in the engine.log instead there is "Z", this means fluentd is unable to parse the log messages.

Version-Release number of selected component (if applicable):
4.2.2.4-0.1.el7

How reproducible:


Steps to Reproduce:
1.Have ovirt engine in utc
2.Check engine.log timestamp
3.

Actual results:
Timestamp example:
2018-03-29 06:53:33,581Z INFO ...

Expected results:
2018-03-29 06:53:33,581+00 INFO ...

Additional info:

Comment 1 Martin Perina 2018-03-29 08:44:22 UTC
Nothing is broken, engine logs comply with ISO 8601 [1] standard, where Z is correct identification for UTC time zone.

We are using "X" [2] to identify that we want logs with ISO 8601 time zone, there's no option how to control that "+00:00" is used instead of "Z". And what's even more important "Z" is preferred over "+00:00" to identify UTC time zone.

[1] https://en.wikipedia.org/wiki/ISO_8601#Coordinated_Universal_Time_(UTC)
[2] file:///home/mperina/Documents/api-1.8.0/index.html

Comment 2 Martin Perina 2018-03-29 09:06:50 UTC
(In reply to Martin Perina from comment #1)
> Nothing is broken, engine logs comply with ISO 8601 [1] standard, where Z is
> correct identification for UTC time zone.
> 
> We are using "X" [2] to identify that we want logs with ISO 8601 time zone,
> there's no option how to control that "+00:00" is used instead of "Z". And
> what's even more important "Z" is preferred over "+00:00" to identify UTC
> time zone.
> 
> [1] https://en.wikipedia.org/wiki/ISO_8601#Coordinated_Universal_Time_(UTC)
> [2] file:///home/mperina/Documents/api-1.8.0/index.html

Sorry here's correct public link:

[2] https://docs.oracle.com/javase/8/docs/api/java/text/SimpleDateFormat.html

Comment 3 Lukas Svaty 2018-03-29 09:50:00 UTC
Reopenning on metrics, where we need to support this format from the fluentd side.

Comment 4 Lukas Svaty 2018-04-19 13:44:36 UTC
verified in ovirt-engine-metrics-1.1.4-1.el7ev.noarch
Timestamp type: 2018-04-19 13:43:44,043Z

Comment 5 Sandro Bonazzola 2018-05-10 06:28:46 UTC
This bugzilla is included in oVirt 4.2.3 release, published on May 4th 2018.

Since the problem described in this bug report should be
resolved in oVirt 4.2.3 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.


Note You need to log in before you can comment on or make changes to this bug.