Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1561932

Summary:	[RFE] Can not disable Host to VM affinity rule
Product:	Red Hat Enterprise Virtualization Manager	Reporter:	Roman Hodain <rhodain>
Component:	ovirt-engine	Assignee:	Andrej Krejcir <akrejcir>
Status:	CLOSED ERRATA	QA Contact:	Polina <pagranat>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	4.1.10	CC:	alukiano, apinnick, bugs, lsurette, mgoldboi, msivak, nobody, rbalakri, Rhev-m-bugs, rhodain, sfroemer, srevivo, ykaul
Target Milestone:	ovirt-4.2.3	Keywords:	FutureFeature, TestOnly
Target Release:	---	Flags:	lsvaty: testing_plan_complete-
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Enhancement
Doc Text:		Story Points:	---
Clone Of:	1493149	Environment:
Last Closed:	2018-05-15 17:48:31 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	SLA	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1493149
Bug Blocks:

Description Roman Hodain 2018-03-29 08:31:45 UTC

+++ This bug was initially created as a clone of Bug #1493149 +++

Description of problem:
Once enabled "host to VM" affinity rule under affinity group cannot be disabled.

Version-Release number of selected component (if applicable):
rhevm-4.1.6.2-0.1.el7.noarch

How reproducible:
Always

Steps to Reproduce:
1. Create affinity group with host to VM affinity enabled
<affinity_group>
 <name>test</name>
 <enforcing>true</enforcing>
 <hosts_rule>
  <enabled>true</enabled>
  <enforcing>true</enforcing>
  <positive>false</positive>
 </hosts_rule>
 <positive>true</positive>
 <vms_rule>
  <enabled>true</enabled>
  <enforcing>true</enforcing>
  <positive>true</positive>
 </vms_rule>
</affinity_group>
2. Disable "host to vm" affinity rule
<affinity_group>
 <hosts_rule>
  <enabled>false</enabled>
  <enforcing>true</enforcing>
  <positive>false</positive>
 </hosts_rule>
</affinity_group>
3.

Actual results:
<affinity_group href="/ovirt-engine/api/clusters/00000002-0002-0002-0002-00000000017a/affinitygroups/a2cdfe24-5087-4d09-a02d-7cfb9a3d43b3" id="a2cdfe24-5087-4d09-a02d-7cfb9a3d43b3">
 <name>test</name>
 <link href="/ovirt-engine/api/clusters/00000002-0002-0002-0002-00000000017a/affinitygroups/a2cdfe24-5087-4d09-a02d-7cfb9a3d43b3/vms"rel="vms"/>
 <enforcing>true</enforcing>
 <hosts_rule>
  <enabled>true</enabled> !!! not updated !!!
  <enforcing>true</enforcing>
  <positive>false</positive>
 </hosts_rule>
....

Expected results:
Host to VM affinity rule must be disabled

Additional info:
Bug actual for REST and UI

--- Additional comment from Martin Sivák on 2017-10-12 07:35:35 EDT ---

This is not supported, host affinity is always enabled. You can only disable it by deleting the rule.

--- Additional comment from Roman Hodain on 2018-03-29 04:27:23 EDT ---

This is very confusing as the WebAdmin allows the user to disable the affinity for the hosts. It just does not persist the state.

To me, it rather feels like the disable state should be the same as not filling the list of the hosts. Because if you do not set any hosts the force the VMs to run out of any host or force them to run on any.

That is from the user perspective. Not talking about the implementation.

What do you think Martin?

Comment 1 Martin Sivák 2018-04-18 13:49:43 UTC

This has already been fixed as part of different bug.

Comment 2 Steffen Froemer 2018-04-18 15:59:14 UTC

(In reply to Martin Sivák from comment #1)
> This has already been fixed as part of different bug.

Can you please give more details?
Does this mean, it will be possible in RHV-4.2 GA?

Comment 3 Martin Sivák 2018-04-18 16:06:13 UTC

Yes, we believe it should be working as expected there. QE might want to verify that though before we pronounce it fixed.

Comment 4 Steffen Froemer 2018-04-18 17:48:46 UTC

Sounds great, thanks. 
One more thing, are the bits already included in rhv-4.2 beta-3?

Comment 5 Polina 2018-04-26 12:23:51 UTC

verified on rhv-release-4.2.3-2-001.noarch

steps for reproduce are performed by both - UI and Rest.

Step1.
POST https://{{host}}/ovirt-engine/api/clusters/de53e75b-b4b0-4252-9e94-af5098c45325/affinitygroups
<affinity_group>
 <name>test</name>
 <enforcing>true</enforcing>
 <hosts_rule>
  <enabled>true</enabled>
  <enforcing>true</enforcing>
  <positive>false</positive>
 </hosts_rule>
 <positive>true</positive>
 <vms_rule>
  <enabled>true</enabled>
  <enforcing>true</enforcing>
  <positive>true</positive>
 </vms_rule>
</affinity_group>


Step2. 
PUT https://{{host}}/ovirt-engine/api/clusters/de53e75b-b4b0-4252-9e94-af5098c45325/affinitygroups/4bd31a35-d3eb-4be5-b266-c880e9104a8c
<affinity_group>
 <hosts_rule>
  <enabled>false</enabled>
  <enforcing>true</enforcing>
  <positive>false</positive>
 </hosts_rule>
</affinity_group>

Result:
<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<affinity_group href="/ovirt-engine/api/clusters/de53e75b-b4b0-4252-9e94-af5098c45325/affinitygroups/4bd31a35-d3eb-4be5-b266-c880e9104a8c" id="4bd31a35-d3eb-4be5-b266-c880e9104a8c">
    <name>test</name>
    <link href="/ovirt-engine/api/clusters/de53e75b-b4b0-4252-9e94-af5098c45325/affinitygroups/4bd31a35-d3eb-4be5-b266-c880e9104a8c/vms" rel="vms"/>
    <enforcing>true</enforcing>
    <hosts_rule>
        <enabled>false</enabled>
        <enforcing>true</enforcing>
        <positive>false</positive>
    </hosts_rule>
    <positive>true</positive>
    <vms_rule>
        <enabled>true</enabled>
        <enforcing>true</enforcing>
        <positive>true</positive>
    </vms_rule>
    <cluster href="/ovirt-engine/api/clusters/de53e75b-b4b0-4252-9e94-af5098c45325" id="de53e75b-b4b0-4252-9e94-af5098c45325"/>
    <hosts/>
    <vms/>
</affinity_group>

Comment 10 errata-xmlrpc 2018-05-15 17:48:31 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2018:1488

Comment 11 Franta Kust 2019-05-16 13:03:36 UTC

BZ<2>Jira Resync