RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1561960 - 'writeback' attribute is missing in 'BlockdevCacheOptions'
Summary: 'writeback' attribute is missing in 'BlockdevCacheOptions'
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: qemu-kvm-rhev
Version: 7.5
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: rc
: ---
Assignee: Kevin Wolf
QA Contact: CongLi
URL:
Whiteboard:
Depends On:
Blocks: 760547 1558125
TreeView+ depends on / blocked
 
Reported: 2018-03-29 09:18 UTC by Peter Krempa
Modified: 2018-04-03 09:26 UTC (History)
11 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-04-03 09:26:46 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Description Peter Krempa 2018-03-29 09:18:03 UTC
Description of problem:
The legacy cache modes 'none', 'writeback' and 'unsafe' require setting 'cache.writeback' to true, but the QAPI schema does not provide this attribute when adding the image via blockdev/blockdev add.

Version-Release number of selected component (if applicable):
Current upstream git, so downstream versions are affected as well.

How reproducible:
100%

Steps to Reproduce:
1. Look for 'writeback' attribute in  'BlockdevCacheOptions' or the equivalent traversal in the schema returned by 'query-qmp-schema' (blockdev-add->arg-type->cache)

Actual results:
only 'direct' and 'no-flush' attributes are present

Expected results:
'writeback' is present as well.

Additional info:
This is necessary for libvirt to use blockdev-add, since we support all the cache modes as described by this table (taken from qemu-options.hx)

              │ cache.writeback   cache.direct   cache.no-flush                 
 ─────────────┼─────────────────────────────────────────────────                 
 writeback    │ on                off            off                             
 none         │ on                on             off                             
 writethrough │ off               off            off                             
 directsync   │ off               on             off                             
 unsafe       │ on                off            on

Comment 1 Kevin Wolf 2018-04-03 09:26:46 UTC
"cache.writeback" is not a backend option, but a frontend one that can differ between multiple users of a backend (e.g. the guest device needs writethrough, but a block job doesn't). Consequently, it can't be set in -blockdev, but when configuring the users of the node.

The option that you're looking for is write-cache=on|off in -device.


Note You need to log in before you can comment on or make changes to this bug.