Bug 1562089 - Nics are Provisioned out of Order for VMware Service Provision
Summary: Nics are Provisioned out of Order for VMware Service Provision
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: Automate
Version: 5.8.0
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: GA
: 5.10.0
Assignee: Adam Grare
QA Contact: Kedar Kulkarni
URL:
Whiteboard:
Depends On:
Blocks: 1562235 1562237
TreeView+ depends on / blocked
 
Reported: 2018-03-29 13:50 UTC by myoder
Modified: 2021-06-10 15:35 UTC (History)
9 users (show)

Fixed In Version: 5.10.0.0
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 1562235 1562237 (view as bug list)
Environment:
Last Closed: 2019-02-11 14:01:03 UTC
Category: Bug
Cloudforms Team: VMware
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Comment 5 Greg McCullough 2018-03-29 17:13:50 UTC
Assigning to adam to get credit for the PR.  :)

Comment 6 CFME Bot 2018-03-29 17:18:04 UTC
New commit detected on ManageIQ/manageiq-providers-vmware/master:

https://github.com/ManageIQ/manageiq-providers-vmware/commit/282f0c05c53b9a00321227a1a91e42247074cf6e
commit 282f0c05c53b9a00321227a1a91e42247074cf6e
Author:     Adam Grare <agrare>
AuthorDate: Thu Mar 29 12:07:29 2018 -0400
Commit:     Adam Grare <agrare>
CommitDate: Thu Mar 29 12:07:29 2018 -0400

    Sort unitNumber as an integer not a string

    The get_network_adapters method was sorting NICs by their unitNumber as
    an integer.  This was causing '10' to be sorted before '7', '8', and
    '9'.

    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1562089

 app/models/manageiq/providers/vmware/infra_manager/provision/configuration/network.rb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comment 7 Greg McCullough 2018-03-29 17:20:01 UTC
Issue re-cap - The VMware unitNumber value was being sorted assuming it was an integer but was actually a string.  Once the unitNumber went above 9 the sort order was wrong.

unitNumbers were: 7, 8, 9, 10, 11
and were sorted as: "10", "11", "7", "8", "9"

Comment 14 Greg McCullough 2018-11-13 13:29:27 UTC
You should be able to find "Config spec:" in evm.log which will dump the config spec structure we send to VMware to help confirm the ordering.

Comment 16 Kedar Kulkarni 2018-11-15 21:56:25 UTC
On 5.10.0.20 I was able to attach the NICs in the order that I wanted.


Note You need to log in before you can comment on or make changes to this bug.