Bug 156230 - lablgtk - FC4 rebuild failed
lablgtk - FC4 rebuild failed
Status: CLOSED RAWHIDE
Product: Fedora
Classification: Fedora
Component: lablgtk (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Gérard Milmeister
Fedora Extras Quality Assurance
:
Depends On:
Blocks: FE4Target 158645
  Show dependency treegraph
 
Reported: 2005-04-28 09:15 EDT by Michael Schwendt
Modified: 2007-11-30 17:11 EST (History)
3 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2005-05-28 23:42:31 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)
Patch for gcc4 build (361 bytes, patch)
2005-05-10 06:16 EDT, Ignacio Vazquez-Abrams
no flags Details | Diff

  None (edit)
Description Michael Schwendt 2005-04-28 09:15:09 EDT
This package failed to rebuild for FC4 Development around 2005-04-11 after an
automated release bump.

Build failure logs at: http://fedoraproject.org/extras/development/build-logs/
Comment 1 Ignacio Vazquez-Abrams 2005-05-10 06:16:12 EDT
Created attachment 114198 [details]
Patch for gcc4 build

Give this one a try.
Comment 2 Toshio Kuratomi 2005-05-22 17:49:27 EDT
Hey Ignacio, I was looking at your fix:
 
-  Pointer_val(*glob_root) = NULL;
+  Field(*glob_root, 1) = NULL;

and found that it still throws a (harmless?) warning:

ml_panel.c: In function 'weak_notify':
ml_panel.c:131: warning: assignment makes integer from pointer without a cast

Is there some reason the folloning is incorrect?

 static void weak_notify(gpointer data, GObject *applet)
 {
   value *glob_root = data;
-  Pointer_val(*glob_root) = NULL;
+  *glob_root = (value)NULL;
   ml_global_root_destroy(glob_root);
 }

Casting has always been my least favorite area of C so I thought running it by
you first would be best.
Comment 3 Ignacio Vazquez-Abrams 2005-05-22 23:19:00 EDT
Your code is incorrect because it replaces the entire contents as opposed to jus
that one field. You can assign 0 instead of NULL if you want to ditch that last
warning.
Comment 4 Toshio Kuratomi 2005-05-23 06:44:20 EDT
Thanks, I'll change it to this:
  Field(*glob_root, 1) = 0;
Comment 5 Colin Charles 2005-05-24 12:52:46 EDT
changed arch to all. unison rebuild fails because of this.
Comment 6 Toshio Kuratomi 2005-05-25 11:20:49 EDT
Hmm - the value type is defined in <caml/mlvales.h>:
  typdef long value;
So that means glob_root is pointing at a 64 bit integer (on x86_64).  This seems
to be the most expressive way to put it:
  Field(*glob_root, 1) = (long)NULL;
Does that seem right to you?
Comment 7 Ignacio Vazquez-Abrams 2005-05-25 12:54:04 EDT
Honestly, I don't know enough about Ocaml's internals to say yes or no wrt that.
If it works, then feel free to use it.
Comment 8 Toshio Kuratomi 2005-05-26 15:14:34 EDT
Patch added and submitted for build
Comment 9 Toshio Kuratomi 2005-05-28 17:42:05 EDT
This has been built -- 2.4.0-5

Note You need to log in before you can comment on or make changes to this bug.