Bug 1563154 - galera: Partial Fedora build flags injection
Summary: galera: Partial Fedora build flags injection
Keywords:
Status: CLOSED EOL
Alias: None
Product: Fedora
Classification: Fedora
Component: galera
Version: 28
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Michal Schorm
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1546787
Blocks: Fedora28BuildFlags
TreeView+ depends on / blocked
 
Reported: 2018-04-03 09:40 UTC by Florian Weimer
Modified: 2019-05-28 19:55 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-05-28 19:55:59 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Florian Weimer 2018-04-03 09:40:54 UTC
/usr/sbin/garbd and /usr/lib64/galera/libgalera_smm.so in galera-25.3.23-1.fc28.x86_64 have not been linked with the standard Fedora linker flags (LDFLAGS) from redhat-rpm-config.

The RPM spec file does not inject LDFLAGS at all:

CPPFLAGS="%{optflags}"
CPPFLAGS=`echo $CPPFLAGS| sed -e "s|-Wp,-D_GLIBCXX_ASSERTIONS||g" `
export CPPFLAGS

scons %{?_smp_mflags} strict_build_flags=0

See https://src.fedoraproject.org/rpms/redhat-rpm-config/blob/master/f/buildflags.md for information on RPM macros and environment variables provided by the build environment.

Comment 1 Michal Schorm 2018-04-03 12:15:13 UTC
I know about this issue.

I'm trying to solve it with the upstream of MariaDB (which galera tarball we use), whose trying to solve it with Galera upstream.

--

How big issue is it for Fedora?
Does that break anything else I'm not aware of?

Comment 2 Florian Weimer 2018-04-03 12:33:04 UTC
(In reply to Michal Schorm from comment #1)
> How big issue is it for Fedora?

It was decided a couple of Fedora releases ago to use hardening flags across all the packages:

https://fedoraproject.org/wiki/Changes/Harden_All_Packages

So the package is failing a Fedora 23 release goal due to this bug.

> Does that break anything else I'm not aware of?

We have a downstream requirement to use the hardening flags during build, and would like to see this fixed upstream/in Fedora.

Comment 3 Ben Cotton 2019-05-02 21:54:38 UTC
This message is a reminder that Fedora 28 is nearing its end of life.
On 2019-May-28 Fedora will stop maintaining and issuing updates for
Fedora 28. It is Fedora's policy to close all bug reports from releases
that are no longer maintained. At that time this bug will be closed as
EOL if it remains open with a Fedora 'version' of '28'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 28 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 4 Ben Cotton 2019-05-28 19:55:59 UTC
Fedora 28 changed to end-of-life (EOL) status on 2019-05-28. Fedora 28 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.


Note You need to log in before you can comment on or make changes to this bug.