Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.
RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.

Bug 1563259

Summary: firewall-cmd doesn't check ipset return value correctly
Product: Red Hat Enterprise Linux 7 Reporter: Marcelo Ricardo Leitner <mleitner>
Component: firewalldAssignee: Eric Garver <egarver>
Status: CLOSED ERRATA QA Contact: Jiri Peska <jpeska>
Severity: high Docs Contact:
Priority: high    
Version: 7.5CC: jmaxwell, jpeska, mleitner, todoleza
Target Milestone: rc   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: firewalld-0.6.3-1.el7 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-08-06 12:03:14 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1637204    
Bug Blocks: 1654714    

Description Marcelo Ricardo Leitner 2018-04-03 13:08:35 UTC
Description of problem:
firewall-cmd gave success on command line, but on syslog we actually saw:
Abr 03 09:55:15 linux.eocp.lan firewalld[1109]: ERROR: '/usr/sbin/ipset add sites_direto 2.3.4.0/24 -exist' failed: ipset v6.29:
 Hash is full, cannot add more elements

and the entry really wasn't there.

The issue regarding the hash being full is known, it is because the hash was of type 'ip', and adding subnets to it causes a lot of IP addresses to be added. 

The issue that I'm reporting is really the fact that firewall-cmd said 'success' on command line while ipset command actually failed.


Version-Release number of selected component (if applicable):
firewalld-0.4.4.4-6.el7.noarch
ipset-6.29-1.el7.x86_64


How reproducible:
Always

Steps to Reproduce:
1.Create a hash of type hash:ip 
2.Add several subnets
3.Check for syslog for ipset failures, while firewall-cmd had said success

Comment 2 Eric Garver 2018-04-10 14:05:16 UTC
Marcelo,

Did you use the --permanent option and --reload? Can you show the actual command you issued?

Comment 3 Marcelo Ricardo Leitner 2018-04-10 14:51:25 UTC
Sorry Eric, I can't because I don't have it anymore.
AFAIR I didn't use neither --permanent or --reload, but just tried to add an entry to the set that was already up.

Comment 4 Eric Garver 2018-09-17 16:02:28 UTC
Upstream:

    31b3ccfe109f ("fw_ipset: raise FirewallError if backend command fails")

Comment 9 errata-xmlrpc 2019-08-06 12:03:14 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2019:2024