Spec URL: https://thm.fedorapeople.org/lxcfs/lxcfs.spec SRPM URL: https://thm.fedorapeople.org/lxcfs/lxcfs-3.0.0-1.fc29.src.rpm Description: LXCFS is a simple userspace filesystem designed to work around some current limitations of the Linux kernel. Specifically, it's providing two main things - A set of files which can be bind-mounted over their /proc originals to provide CGroup-aware values. - A cgroupfs-like tree which is container aware. The code is pretty simple, written in C using libfuse. The main driver for this work was the need to run systemd based containers as a regular unprivileged user while still allowing systemd inside the container to interact with cgroups. Now with the introduction of the cgroup namespace in the Linux kernel, that part is no longer necessary on recent kernels and focus is now on making containers feel more like a real independent system through the proc masking feature. Fedora Account System Username: thm Scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=26164986
Reviewing now
Fine => Approved! Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "MIT/X11 (BSD like)", "FSF All Permissive", "Unknown or generated", "*No copyright* Apache (v2.0)". 50 files have unknown license. Detailed output of licensecheck in /home/lupinix/review/1563668-lxcfs/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package does not own files or directories owned by other packages. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in lxcfs- debuginfo , lxcfs-debugsource [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Uses parallel make %{?_smp_mflags} macro. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: There are rpmlint messages (see attachment). [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: lxcfs-3.0.0-1.fc29.x86_64.rpm lxcfs-debuginfo-3.0.0-1.fc29.x86_64.rpm lxcfs-debugsource-3.0.0-1.fc29.x86_64.rpm lxcfs-3.0.0-1.fc29.src.rpm lxcfs.x86_64: W: spelling-error %description -l en_US proc -> crop, prov, pro lxcfs.x86_64: W: spelling-error %description -l en_US cgroupfs -> groups lxcfs.x86_64: W: spelling-error %description -l en_US libfuse -> lib fuse, lib-fuse, libelous lxcfs.x86_64: W: spelling-error %description -l en_US cgroups -> groups, c groups lxcfs.x86_64: W: spelling-error %description -l en_US cgroup -> croup, group, c group lxcfs.x86_64: W: empty-%postun lxcfs-debuginfo.x86_64: E: useless-provides debuginfo(build-id) lxcfs-debugsource.x86_64: W: no-documentation lxcfs.src: W: spelling-error %description -l en_US proc -> crop, prov, pro lxcfs.src: W: spelling-error %description -l en_US cgroupfs -> groups lxcfs.src: W: spelling-error %description -l en_US libfuse -> lib fuse, lib-fuse, libelous lxcfs.src: W: spelling-error %description -l en_US cgroups -> groups, c groups lxcfs.src: W: spelling-error %description -l en_US cgroup -> croup, group, c group 4 packages and 0 specfiles checked; 1 errors, 12 warnings. Rpmlint (debuginfo) ------------------- Checking: lxcfs-debuginfo-3.0.0-1.fc29.x86_64.rpm lxcfs-debuginfo.x86_64: E: useless-provides debuginfo(build-id) 1 packages and 0 specfiles checked; 1 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- sh: /usr/bin/python: No such file or directory lxcfs-debugsource.x86_64: W: no-documentation lxcfs-debuginfo.x86_64: E: useless-provides debuginfo(build-id) lxcfs.x86_64: W: spelling-error %description -l en_US proc -> crop, prov, pro lxcfs.x86_64: W: spelling-error %description -l en_US cgroupfs -> groups lxcfs.x86_64: W: spelling-error %description -l en_US libfuse -> lib fuse, lib-fuse, libelous lxcfs.x86_64: W: spelling-error %description -l en_US cgroups -> groups, c groups lxcfs.x86_64: W: spelling-error %description -l en_US cgroup -> croup, group, c group lxcfs.x86_64: W: empty-%postun 3 packages and 0 specfiles checked; 1 errors, 7 warnings. Requires -------- lxcfs-debugsource (rpmlib, GLIBC filtered): lxcfs-debuginfo (rpmlib, GLIBC filtered): lxcfs (rpmlib, GLIBC filtered): /bin/sh libc.so.6()(64bit) libdl.so.2()(64bit) libfuse.so.2()(64bit) libfuse.so.2(FUSE_2.6)(64bit) libpthread.so.0()(64bit) lxc-templates rtld(GNU_HASH) systemd Provides -------- lxcfs-debugsource: lxcfs-debugsource lxcfs-debugsource(x86-64) lxcfs-debuginfo: debuginfo(build-id) lxcfs-debuginfo lxcfs-debuginfo(x86-64) lxcfs: liblxcfs.so()(64bit) lxcfs lxcfs(x86-64) Unversioned so-files -------------------- lxcfs: /usr/lib64/lxcfs/liblxcfs.so Source checksums ---------------- https://linuxcontainers.org/downloads/lxcfs/lxcfs-3.0.0.tar.gz : CHECKSUM(SHA256) this package : 204044eb22299cf03fc32580810cdc488eefe8cc277864d1937daf36ea98239a CHECKSUM(SHA256) upstream package : 204044eb22299cf03fc32580810cdc488eefe8cc277864d1937daf36ea98239a Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -v -b 1563668 -m fedora-rawhide-x86_64 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
(fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/lxcfs
lxcfs-3.0.0-1.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-0c74b61058
lxcfs-3.0.0-1.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2018-fcd4f09b1f
lxcfs-3.0.0-1.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-08e4b840ec
lxcfs-3.0.0-1.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-0c74b61058
lxcfs-3.0.0-1.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-08e4b840ec
lxcfs-3.0.0-1.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-fcd4f09b1f
lxcfs-3.0.0-1.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.
lxcfs-3.0.0-1.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.
lxcfs-3.0.0-1.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report.