Bug 1564151
| Summary: | lsmcli volume-replicate-range is missing checking for src_starts, dst_starts and count | ||
|---|---|---|---|
| Product: | Red Hat Enterprise Linux 7 | Reporter: | Filip Suba <fsuba> |
| Component: | libstoragemgmt | Assignee: | Tony Asleson <tasleson> |
| Status: | CLOSED ERRATA | QA Contact: | Jakub Krysl <jkrysl> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 7.5 | CC: | jkrysl, tasleson |
| Target Milestone: | rc | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2019-08-06 12:40:24 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
*** Bug 1583753 has been marked as a duplicate of this bug. *** libstoragemgmt-1.7.2-1.el7.x86_64
lsmcli -u "sim://" volume-replicate-range --count='100' --src-vol='VOL_ID_00001' --rep-type='CLONE' --dst-vol='VOL_ID_00002' --dst-start='WRONG' --src-start='0'
usage: lsmcli volume-replicate-range [-h] [-v] [-u <URI>] [-P] [-H] [-t <SEP>]
[-e] [-f] [-w CHILD_WAIT] [--header] [-b]
[-s] --src-vol <SRC_VOL_ID> --dst-vol
<DST_VOL_ID> --rep-type <REP_TYPE>
--src-start <SRC_START_BLK> --dst-start
<DST_START_BLK> --count <BLK_COUNT>
lsmcli volume-replicate-range: error: argument --dst-start: invalid: not a positive integer value 'WRONG'
lsmcli -u "sim://" volume-replicate-range --count='100' --src-vol='VOL_ID_00001' --rep-type='CLONE' --dst-vol='VOL_ID_00002' --dst-start='0' --src-start='WRONG'
usage: lsmcli volume-replicate-range [-h] [-v] [-u <URI>] [-P] [-H] [-t <SEP>]
[-e] [-f] [-w CHILD_WAIT] [--header] [-b]
[-s] --src-vol <SRC_VOL_ID> --dst-vol
<DST_VOL_ID> --rep-type <REP_TYPE>
--src-start <SRC_START_BLK> --dst-start
<DST_START_BLK> --count <BLK_COUNT>
lsmcli volume-replicate-range: error: argument --src-start: invalid: not a positive integer value 'WRONG'
lsmcli -u "sim://" volume-replicate-range --count='WRONG' --src-vol='VOL_ID_00001' --rep-type='CLONE' --dst-vol='VOL_ID_00002' --dst-start='0' --src-start='0'
usage: lsmcli volume-replicate-range [-h] [-v] [-u <URI>] [-P] [-H] [-t <SEP>]
[-e] [-f] [-w CHILD_WAIT] [--header] [-b]
[-s] --src-vol <SRC_VOL_ID> --dst-vol
<DST_VOL_ID> --rep-type <REP_TYPE>
--src-start <SRC_START_BLK> --dst-start
<DST_START_BLK> --count <BLK_COUNT>
lsmcli volume-replicate-range: error: argument --count: invalid: not a positive integer value 'WRONG'
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2019:2064 |
Description of problem: When you try to run volume-replicate-range with wrong type in src_starts or dst_starts or count it will return traceback. Traceback (most recent call last): File "/usr/lib/python2.7/site-packages/lsm/lsmcli/cmdline.py", line 67, in cmd_line_wrapper cli.process(c) File "/usr/lib/python2.7/site-packages/lsm/lsmcli/cmdline.py", line 1809, in process self.args.func(self.args) File "/usr/lib/python2.7/site-packages/lsm/lsmcli/cmdline.py", line 1532, in volume_replicate_range long(counts[b]))) ValueError: invalid literal for long() with base 10: 'aaa' Version-Release number of selected component (if applicable): libstoragemgmt 1.6.1, 1.4.0-1 How reproducible: 100% Steps to Reproduce: 1. lsmcli -u 'sim://' volume-create --name VOL_ID_00001 --size 1G --pool POOL_ID_00001 2. 1. lsmcli -u 'sim://' volume-create --name VOL_ID_00002 --size 1G --pool POOL_ID_00001 3. lsmcli -u "sim://" volume-replicate-range -f --src-vol=VOL_ID_00001 --dst-vol=VOL_ID_00002 --rep-type=COPY --src-start=0.0 --dst-start=0.0 --count=100.0 --src-start=aaa --dst-start=aaa --count=aaa Actual results: Returns traceback. Expected results: It should return some error message. Additional info: