Description of problem:
When OpenSSH's client settings specify ConnectTimeout as 0 (zero), net/ssh will immediately timeout when attempting an SSH connection. In contrast, openssh-client (the ssh command) will complete successfully using the exact same client config file.

This is preventing Satellite 6.3.0 from running remote execution jobs if "ConnectTimeout 0" is set in either ~foreman-proxy/.ssh/config or /etc/ssh/ssh_config.


Version-Release number of selected component (if applicable):
tfm-rubygem-net-ssh-4.0.1-2.el7sat.noarch


How reproducible:
Every time.

Steps to Reproduce:
1. Add this content to /etc/ssh/ssh_config on a Satellite 6.3:
Host *
  ConnectTimeout 0
2. Attempt to run any remote execution job.


Actual results:
Fails every time with:
Error initializing command: Net::SSH::ConnectionTimeout -  Net::SSH::ConnectionTimeout
Exit status: EXCEPTION


Expected results:
It should interpret "ConnectTimeout 0" exactly like the openssh client utility does. Apparently openssh client will ignore ConnectTimeout if set to 0.


Additional info:

This issue is new to Satellite 6.3.0.

Changing the @server_version declaration in line 84 of usr/share/gems/gems/net-ssh-4.0.1/lib/net/ssh/transport/session.rb to set any integer instead of relying on options[:timeout] resolved the issue during my tests.