Need to validate nic templates prior to starting a deployment.
Starting a deployment of overcloud. It misses validating nic-config template.
This may lead to https://bugzilla.redhat.com/show_bug.cgi?id=1559536.
We need to ensure the nic templates are of the right version/format.
Bob do you have a way of detecting the old vs new format that we can use during the deployment to fail fast? It seems that if the old format is used, the deployment just times out which is not ideal.
We have the check in THT/tools/yaml_validate.py to error if an old nice config file is in use, similar to if the template version is other than "pike", "queens" etc. I guess that is not being invoked at the start of a deployment. Will look into it...
This needs to be added as part of tripleo-validations.
In addition, a check should be done for nic config files that have invalid bridge name definitions, e.g.:
These invalid bridge names can occur if the template is partially converted but the conversion failed.