Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1566948

Summary:	Preview of snapshot with memory crashes on missing `serial' attribute
Product:	[oVirt] vdsm	Reporter:	Milan Zamazal <mzamazal>
Component:	Core	Assignee:	Francesco Romani <fromani>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Vitalii Yerys <vyerys>
Severity:	high	Docs Contact:
Priority:	unspecified
Version:	4.20.23	CC:	bugs, michal.skrivanek
Target Milestone:	ovirt-4.2.3	Flags:	rule-engine: ovirt-4.2+
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-05-10 06:30:20 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Virt	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Milan Zamazal 2018-04-13 08:20:02 UTC

Description of problem:

When I run preview of snapshot with memory in basic-suite-4.2 oVirt system test posted at https://gerrit.ovirt.org/#/c/86571/4, the VM fails to start with the following error:

  Traceback (most recent call last):
    File "/usr/lib/python2.7/site-packages/vdsm/API.py", line 225, in create
      return self._cif.createVm(vmParams)
    File "/usr/lib/python2.7/site-packages/vdsm/clientIF.py", line 558, in createVm
      vm = Vm(self, vmParams, vmRecover)
    File "/usr/lib/python2.7/site-packages/vdsm/virt/vm.py", line 360, in __init__
      self._src_domain_xml, params['xml'])
    File "/usr/lib/python2.7/site-packages/vdsm/virt/vm.py", line 2937, in _correct_disk_volumes_from_xml
      change_disk(element, devices, self.log)
    File "/usr/lib/python2.7/site-packages/vdsm/virt/vmdevices/storagexml.py", line 260, in change_disk
      serial = vmxml.text(vmxml.find_first(disk_element, 'serial'))
    File "/usr/lib/python2.7/site-packages/vdsm/virt/vmxml.py", line 112, in find_first
      raise NotFound((element, tag,))
  NotFound: (<Element 'disk' at 0x7f64a418a990>, 'serial')

Version-Release number of selected component (if applicable):

Current Vdsm from ovirt-4.2 branch.

How reproducible:

100%

Steps to Reproduce:

Run the OST from gerrit URL given above on basic-suite-4.2 with current Vdsm ovirt-4.2 branch.

Actual results:

The VM fails to start.

Expected results:

The VM starts from the given snapshot.

Comment 1 Milan Zamazal 2018-04-25 08:01:04 UTC

As for verification, I suggest creating a VM with a CD-ROM and a LUN device, making a snapshot of it and then to preview the snapshot.

Comment 2 Vitalii Yerys 2018-04-26 11:02:21 UTC

Verified with vdsm-4.20.26-1.el7ev.x86_64

Comment 3 Sandro Bonazzola 2018-05-10 06:30:20 UTC

This bugzilla is included in oVirt 4.2.3 release, published on May 4th 2018.

Since the problem described in this bug report should be
resolved in oVirt 4.2.3 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.