Bug 1567221 - Issue checking should ensure required flags are present, even on newer patchsets in gerrit
Summary: Issue checking should ensure required flags are present, even on newer patchs...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: project-infrastructure
Version: mainline
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: bugs@gluster.org
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-04-13 15:16 UTC by Shyamsundar
Modified: 2018-04-16 05:34 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-04-16 05:34:35 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:


Attachments (Terms of Use)

Description Shyamsundar 2018-04-13 15:16:36 UTC
Smoke initially failed stating (Doc/Spec)Approved is missing: https://build.gluster.org/job/comment-on-issue/6270/console

On re-submission it passed: https://build.gluster.org/job/comment-on-issue/6271/console

It should not have, but as the check for the required flags are only on new issues in the commit message when the patchset is not the first, it avoids that check and passes smoke.

As in this line, https://github.com/gluster/glusterfs-patch-acceptance-tests/blob/master/github/handle_github.py#L110 should be out of the new issues in commit message check, and should be run for all issues in the commit message.

This inadvertently provides a workaround, that if smoke is rerun it will pass :)

Comment 1 Nigel Babu 2018-04-16 05:34:35 UTC
This is now fixed. I've also gone ahead and retried all the jobs which passed inadvertently.


Note You need to log in before you can comment on or make changes to this bug.