Description of problem: After uploading a new plan and increasing the controllers count to 3, you can't save the changes. The "Manage Roles" button is still displayed. Only after updating more counters do you get the "Save" and "Cancel" buttons. Version-Release number of selected component (if applicable): openstack-tripleo-ui-8.3.1-2.el7ost.noarch How reproducible: 100% Steps to Reproduce: 1. Upload a new plan and browse to its deployment page 2. Edit the "Controller" role and set its flavor to "control" 3. Save and close the role editing dialog 4. Update the controller count to 3 5. See if you can save the changes... Actual results: No "Save" button Expected results: The "Save" and "Cancel" buttons should appear, and the "Manage Roles" button should disappear. Additional info: After updating the compute role and counters the problem is resolved.
Please attach the plan you used.
I am going to investigate further, but the button should appear in case when the nodes assignment form (the counters) is valid && dirty && !submitting. Was one of the counters red? I assume that when you create plan initially, the controller and compute counts are set to 1. In case when there are no nodes ready yet, both are red so until one of the counts are red the save button will not appear.
The plan is just the default plan which you can create with: tar -czf plan.tgz -C /usr/share/openstack-tripleo-heat-templates/ . Jiri, you are also right. When the plan is new you have to configure the flavors for both the controller role and the compute role, and until then the counters are red. After configuring the 2nd role you get the save button. Is there a way to make it more clear to the user?
Created attachment 1433806 [details] Proposed error message to clarify the situation
@Udi: We can provide an error message describing the situation. Would that be sufficient/helpful? (See attachment)
A message describing the problem can help a lot. For example, if the user changes a counter - check if other counters are red and display something telling the user that the changes will only be savable when all counters are valid.
Liz can you help with the proposed error message linked here https://bugzilla.redhat.com/attachment.cgi?id=1433806
Commented on the patch upstream with suggestion... https://review.openstack.org/#/c/567221/
Verified in openstack-tripleo-ui-9.3.1-0.20180921180341.df30b55.el7ost.noarch
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHEA-2019:0045