Bug 1567902 - smc-tools: Partial Fedora build flags injection
Summary: smc-tools: Partial Fedora build flags injection
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: smc-tools
Version: 28
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Dan Horák
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: Fedora28BuildFlags
TreeView+ depends on / blocked
 
Reported: 2018-04-16 11:51 UTC by Florian Weimer
Modified: 2018-04-27 04:04 UTC (History)
1 user (show)

Fixed In Version: smc-tools-1.0.0-4.fc28
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-04-27 04:04:13 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Florian Weimer 2018-04-16 11:51:22 UTC
/usr/bin/smc_pnet in smc-tools-1.0.0-3.fc28.x86_64 has not been linked with the standard Fedora linker flags (LDFLAGS) from redhat-rpm-config.

According to the build log, CFLAGS are injected, but not LDFLAGS:

cc -Iinclude -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -mcet -fcf-protection -I/usr/include/libnl3 -o smc_pnet smc_pnet.c -lnl-genl-3 -lnl-3

Other binaries in the package are linked with LDFLAGS, so this is likely a makefile problem.

Please address this issue in both Fedora 28 and rawhide.  Thanks.

Comment 1 Fedora Update System 2018-04-16 12:21:00 UTC
smc-tools-1.0.0-4.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-16c3bb9eda

Comment 2 Fedora Update System 2018-04-17 03:04:34 UTC
smc-tools-1.0.0-4.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-16c3bb9eda

Comment 3 Fedora Update System 2018-04-27 04:04:13 UTC
smc-tools-1.0.0-4.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.