Bug 1568556 - LiveMerge releases VM lock twice
Summary: LiveMerge releases VM lock twice
Keywords:
Status: CLOSED DUPLICATE of bug 1581158
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: BLL.Virt
Version: 4.2.0
Hardware: Unspecified
OS: Unspecified
unspecified
high
Target Milestone: ovirt-4.3.0
: ---
Assignee: Ravi Nori
QA Contact: Nisim Simsolo
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-04-17 18:37 UTC by Ravi Nori
Modified: 2018-08-01 19:03 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: No Doc Update
Doc Text:
undefined
Clone Of:
Environment:
Last Closed: 2018-08-01 19:03:14 UTC
oVirt Team: Infra
Embargoed:
rule-engine: ovirt-4.3+

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 90482 0 master ABANDONED engine: LiveMerge releases VM lock twice 2018-05-10 15:26:00 UTC

Description Ravi Nori 2018-04-17 18:37:20 UTC 
Description of problem: Deleting a snapshot while the VM is running results in the VM lock being released twice.


Version-Release number of selected component (if applicable): 4.2


How reproducible:


Steps to Reproduce:
1. Create a VM snapshot
2. Run the VM
3. Delete the snapshot

Actual results:
Warning message in logs about lock being released which has already been released

2018-04-17 14:32:50,233-04 WARN  [org.ovirt.engine.core.bll.lock.InMemoryLockManager] (EE-ManagedThreadFactory-engineScheduled-Thread-98) [346c1aeb-bbf5-4ba8-b661-c58f940c3b59] Trying to release exclusive lock which does not exist, lock key: 'd69cf8da-f93b-48e7-a178-deb991a45909VM'

Expected results:
No warning message
Comment 1 Martin Perina 2018-04-18 06:53:08 UTC 
Setting priority to high, because other flow can step in and perform action during the time between child command releases the lock and parent command finishes its execution and try to release the lock again (locks acquired in parent command cannot be released in child commands).
Comment 2 Ravi Nori 2018-08-01 19:03:14 UTC 

*** This bug has been marked as a duplicate of bug 1581158 ***
Note You need to log in before you can comment on or make changes to this bug.