Bug 1568978 - [Tests] PEP8 is broken
Summary: [Tests] PEP8 is broken
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat OpenStack
Classification: Red Hat
Component: openstack-neutron
Version: 12.0 (Pike)
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: z3
: 12.0 (Pike)
Assignee: Bernard Cafarelli
QA Contact: Toni Freger
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-04-18 13:20 UTC by Arie Bregman
Modified: 2018-08-20 12:52 UTC (History)
6 users (show)

Fixed In Version: openstack-neutron-11.0.2-6.el7ost
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-08-20 12:51:30 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
OpenStack gerrit 561698 0 None None None 2018-04-18 14:04:12 UTC
Red Hat Product Errata RHBA-2018:2514 0 None None None 2018-08-20 12:52:43 UTC

Description Arie Bregman 2018-04-18 13:20:27 UTC
Description of problem:

OSP 12 PEP8 is failing suddenly with multiple failures:

./neutron/policy.py:302:13: E731 do not assign a lambda expression, use a def
            conv_func = lambda x: x
            ^
./neutron/db/allowedaddresspairs_db.py:93:17: W503 line break before binary operator
                and port['port'][addr_pair.ADDRESS_PAIRS] != [])
                ^
./neutron/db/db_base_plugin_common.py:71:9: E731 do not assign a lambda expression, use a def
        do_filter = lambda d: {k: v for k, v in d.items() if k in fields}
        ^
./neutron/db/extradhcpopt_db.py:86:33: W503 line break before binary operator
                                and opt['ip_version'] == upd_rec.get(
                                ^
./neutron/db/ipam_backend_mixin.py:761:13: W503 line break before binary operator
            and host and not old_host
            ^
./neutron/db/ipam_backend_mixin.py:762:13: W503 line break before binary operator
            and not old_ips
            ^
./neutron/db/ipam_backend_mixin.py:763:13: W503 line break before binary operator
            and not fixed_ips_requested)
            ^
./neutron/db/l3_db.py:772:17: W503 line break before binary operator
                and subnet['ipv6_address_mode'] is not None):
                ^
./neutron/db/l3_db.py:1554:9: E731 do not assign a lambda expression, use a def


Version-Release number of selected component (if applicable): Latest OSP 12


How reproducible: 100%


Steps to Reproduce:
1. Clone neutron OSP 12
2. Run PEP8 with tox -e pep8

Comment 2 Bernard Cafarelli 2018-04-18 14:04:12 UTC
There were some recent pep8 bumps upstream, the upstream backport was just merged in for stable/pike (in links).
I will backport this downstream so tests can pass until the next sync

Comment 5 errata-xmlrpc 2018-08-20 12:51:30 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2018:2514


Note You need to log in before you can comment on or make changes to this bug.