Red Hat Bugzilla – Bug 1569400
Improve prometheus uninstall process
Last modified: 2018-10-05 18:04:22 EDT
Description of problem: Prometheus is deployed to openshift-metrics namespace by default, after undeploying prometheus, prometheus namespace would be deleted, it is better to keep this namespace, maybe some other pods would be deyployed under this namespace Version-Release number of selected component (if applicable): How reproducible: Always Steps to Reproduce: 1. Deploy prometheus and undeploy it 2. Check whether the namespace where prometheus deployed is deleted or not 3. Actual results: prometheus namespace would be deleted Expected results: prometheus namespace should be kept Additional info:
# rpm -qa | grep openshift-ansible openshift-ansible-roles-3.10.0-0.22.0.git.0.b6ec617.el7.noarch openshift-ansible-playbooks-3.10.0-0.22.0.git.0.b6ec617.el7.noarch openshift-ansible-3.10.0-0.22.0.git.0.b6ec617.el7.noarch openshift-ansible-docs-3.10.0-0.22.0.git.0.b6ec617.el7.noarch
I'd prefer to keep the uninstall process as simple as possible, otherwise it's more maintenance to keep the uninstall in sync with the install. Is there something specific that would commonly be deployed to the prometheus namespace?
metrics now is deployed under openshift-metrics namespaces, we should keep the prometheus namespace after undeploying prometheus https://github.com/openshift/openshift-ansible/pull/8649
moving to 3.11 as the change referenced in comment 4 is being reverted and the only thing in openshift-metrics in 3.10 should be the tech preview prometheus stack, which will no longer be in this namespace in 3.11 We may need to address this in 3.11 if metrics-server does get installed into openshift-metrics versus the new openshift-monitoring namespace. Mainly concerned that if someone moves from the old prometheus tech preview installation to the new one that uninstalling the old one doesnt wipe out metrics-server.
It doesn't really matter where metrics-server is installed. You could run multiple during the upgrade, as long as you update the APIService to point to the correct one.
PR: https://github.com/openshift/openshift-ansible/pull/9802
PR for 3.10: https://github.com/openshift/openshift-ansible/pull/9860
Paul, From the PR, ds, svc and other resources are deleted, the prometheus namespace is finally deleted too, and not maintained, the fix has nothing to do with the defect.
Paul, We could close this defect as WONTFIX if the openshift-metrics namespace is deleted after undeploying prometheus, since the openshift-metrics namespace is used only by us now, I am OK with the solution
The updated uninstall should only delete the namespace if there are no other objects present. So the behaviour is the same if prometheus is the only thing installed in the namespace. However, if there is another deployment sharing the namespace, then it won't be deleted. I thought that solved the use case here. If it's better to keep the namespace regardless of whether it contains another deployment, I could just remove that part of the uninstall.
(In reply to Paul Gier from comment #12) > If it's better to keep the namespace regardless of whether it contains > another deployment, I could just remove that part of the uninstall. Since prometheus will be deprecated in 4.0, and there is not other deployment using openshift-metrics namespace now, I think remove the openshift-metrics namespace is OK.
# rpm -qa | grep ansible ansible-2.6.3-1.el7ae.noarch openshift-ansible-docs-3.11.0-0.28.0.git.0.730d4be.el7.noarch openshift-ansible-playbooks-3.11.0-0.28.0.git.0.730d4be.el7.noarch openshift-ansible-3.11.0-0.28.0.git.0.730d4be.el7.noarch openshift-ansible-roles-3.11.0-0.28.0.git.0.730d4be.el7.noarch If only prometheus is using openshift-metrics namespace, ds, svc, configmaps and other resources are deleted, the namespace is kept. If there is not other deployment under openshift-metrics namespace, the openshift-metrics namespace will be deleted