Red Hat Bugzilla – Bug 156959
invalid file mode on created files
Last modified: 2008-06-12 04:24:12 EDT
From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.7) Gecko/20050414 Firefox/1.0.3
Description of problem:
Files are created with an invalid file mode, because the open(..., O_CREAT) call on unzip-5.51-near-4GB.patch line 140 contains no file mode argument. This doesn't seem to cause problems on ext3 (and probably other unix file systems), but does on cifs filesystems.
Version-Release number of selected component (if applicable):
Steps to Reproduce:
1. mount -t cifs //host/share /mnt/cifs
2. cd /mnt/cifs
3. unzip /tmp/file.zip
Actual Results: Error message from unzip:
file.ext: write error (disk full?). Continue? (y/n/^C)
Expected Results: Successful extraction.
can you add mode to open command
(change unzip-5.51-near-4GB.patch line 140
- fd = open(G.filename, O_WRONLY | O_LARGEFILE | O_CREAT);
+ fd = open(G.filename, O_WRONLY | O_LARGEFILE | O_CREAT | O_EXCL | 0600) ;
and test whether is the bug still present.
If there is any problem I can create changed package and attach it here.
I changed line 140 of unzip-5.51-near-4GB.patch to
fd = open(G.filename, O_WRONLY | O_LARGEFILE | O_CREAT, 0666);
and that fixed the bug.
This problem is fixed in unzip-5.51-11. (I use mode 0600.) If there is any
problem please reopen this bug.
Problem has reappeared in unzip-5.52 both version in F8 and RHEL, presumably f9
see bug 227225
We do not keep bugs open against EOL versions of Fedora. Per comment #4
changing version to '8'
Created attachment 306422 [details]
last patch in spec file fixes problem
Very well. I've attached a patch and src.rpm of the latest version.
Alternatively just edit unzip-5.52-near-4GB.patch as described above.
Created attachment 306423 [details]
Thanks, this bug is fixed in unzip-5.52-5 version.