Bug 1570461 - Some component in the openshift master / CLI binaries are trapping CTRL+C twice, not once
Summary: Some component in the openshift master / CLI binaries are trapping CTRL+C twi...
Keywords:
Status: CLOSED DEFERRED
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Master
Version: 3.9.0
Hardware: Unspecified
OS: Unspecified
unspecified
high
Target Milestone: ---
: 3.10.z
Assignee: Stefan Schimanski
QA Contact: Wang Haoran
URL:
Whiteboard:
Depends On:
Blocks: 1557851
TreeView+ depends on / blocked
 
Reported: 2018-04-23 01:44 UTC by Clayton Coleman
Modified: 2019-11-20 19:06 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed:
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)

Description Clayton Coleman 2018-04-23 01:44:12 UTC 
1. Start openshift-router
2. Hit CTRL+C

Actual:

Process does not exit

Expected:

Process exits

If I hit CTRL+C a second time the process exits.  It looks like someone double registered a sig trap handler somewhere in CLI or in the server code.

Marking high because this breaks process signal handling in at minimum the router.
Comment 1 Clayton Coleman 2018-04-23 01:47:49 UTC 
Looks like it is a result of origin/pr/19063
Comment 2 Andrew McDermott 2018-04-23 19:02:20 UTC 
(In reply to Clayton Coleman from comment #1)
> Looks like it is a result of origin/pr/19063

I moved the handling of the signal closer to NewCommandStartNode() but that only works some of the time now (8/10 signal is delivered successfully). Investigating why that is because it was reliable before.
Comment 3 Andrew McDermott 2018-04-27 13:46:44 UTC 
PR: https://github.com/openshift/ose/pull/1221
Comment 4 Andrew McDermott 2018-05-01 12:04:30 UTC 
The revert PR: https://github.com/openshift/ose/pull/1238 until we go fix the issues highlighted in the PR description.
Comment 5 Andrew McDermott 2018-05-15 14:38:45 UTC 
Upstream PR: https://github.com/kubernetes/kubernetes/pull/63859
Comment 8 Stephen Cuppett 2019-11-20 19:06:48 UTC 
OCP 3.6-3.10 is no longer on full support [1]. Marking CLOSED DEFERRED. If you have a customer case with a support exception or have reproduced on 3.11+, please reopen and include those details. When reopening, please set the Target Release to the appropriate version where needed.

[1]: https://access.redhat.com/support/policy/updates/openshift
Comment 9 Stephen Cuppett 2019-11-20 19:06:57 UTC 
OCP 3.6-3.10 is no longer on full support [1]. Marking CLOSED DEFERRED. If you have a customer case with a support exception or have reproduced on 3.11+, please reopen and include those details. When reopening, please set the Target Release to the appropriate version where needed.

[1]: https://access.redhat.com/support/policy/updates/openshift
Note You need to log in before you can comment on or make changes to this bug.