Bugzilla (bugzilla.redhat.com) will be under maintenance for infrastructure upgrades and will not be available on July 31st between 12:30 AM - 05:30 AM UTC. We appreciate your understanding and patience. You can follow status.redhat.com for details.
Bug 1570557 - Review Request: perl-Command-Runner - Run external commands and Perl code refs
Summary: Review Request: perl-Command-Runner - Run external commands and Perl code refs
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Petr Pisar
QA Contact: Fedora Extras Quality Assurance
Depends On:
Blocks: 1570215
TreeView+ depends on / blocked
Reported: 2018-04-23 08:43 UTC by Jitka Plesnikova
Modified: 2018-04-23 14:30 UTC (History)
2 users (show)

Fixed In Version: perl-Command-Runner-0.002-1.fc29
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Last Closed: 2018-04-23 14:30:05 UTC
Type: ---
ppisar: fedora-review+

Attachments (Terms of Use)

Description Jitka Plesnikova 2018-04-23 08:43:48 UTC
Spec URL: https://jplesnik.fedorapeople.org/perl-Command-Runner/perl-Command-Runner.spec
SRPM URL: https://jplesnik.fedorapeople.org/perl-Command-Runner/perl-Command-Runner-0.002-1.fc29.src.rpm

This module runs external commands and Perl code refs.

Fedora Account System Username: jplesnik@redhat.com

Comment 1 Petr Pisar 2018-04-23 09:20:51 UTC
Url and Source0 addresses are Ok.
Source archive (SHA-256: 3d1f46365892c5b43adcadac296c9bc831374b282baf9e1eb8187f643facf5f0) is original. Ok.
Summary verified from lib/Command/Runner.pm. Ok.
Description verified from lib/Command/Runner.pm. Ok.

TODO: Expand `refs' in the summary and the description to `references'.

License verified from LICENSE and lib/Command/Runner.pm. Ok.
No XS code, noarch BuildArch is Ok.

FIX: Because Win32::ShellQuote is not available, t/02_basic.t is skipped and thus there is no point in build-requiring String::ShellQuote. Don't build-require String::ShellQuote or, rather patch out the "use Test::Needs 'Win32::ShellQuote';" code and report a bug to the upstream to load it only on Windows.

All tests pass. Ok.

$ rpmlint perl-Command-Runner.spec ../SRPMS/perl-Command-Runner-0.002-1.fc29.src.rpm ../RPMS/noarch/perl-Command-Runner-0.002-1.fc29.noarch.rpm 
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
rpmlint is Ok.

$ rpm -q -lv -p ../RPMS/noarch/perl-Command-Runner-0.002-1.fc29.noarch.rpm 
drwxr-xr-x    2 root    root                        0 Apr 23 11:11 /usr/share/doc/perl-Command-Runner
-rw-r--r--    1 root    root                      163 Apr 21 20:31 /usr/share/doc/perl-Command-Runner/Changes
-rw-r--r--    1 root    root                     2028 Apr 21 20:31 /usr/share/doc/perl-Command-Runner/README
drwxr-xr-x    2 root    root                        0 Apr 23 11:11 /usr/share/licenses/perl-Command-Runner
-rw-r--r--    1 root    root                    18400 Apr 21 20:31 /usr/share/licenses/perl-Command-Runner/LICENSE
-rw-r--r--    1 root    root                     2785 Apr 23 11:11 /usr/share/man/man3/Command::Runner.3pm.gz
-rw-r--r--    1 root    root                       20 Apr 23 11:11 /usr/share/man/man3/Command::Runner::LineBuffer.3pm.gz
drwxr-xr-x    2 root    root                        0 Apr 23 11:11 /usr/share/perl5/vendor_perl/Command
drwxr-xr-x    2 root    root                        0 Apr 23 11:11 /usr/share/perl5/vendor_perl/Command/Runner
-rw-r--r--    1 root    root                     8313 Apr 21 20:31 /usr/share/perl5/vendor_perl/Command/Runner.pm
-rw-r--r--    1 root    root                     1151 Apr 21 20:31 /usr/share/perl5/vendor_perl/Command/Runner/LineBuffer.pm
File layout and permissions are Ok.

$ rpm -q --requires -p ../RPMS/noarch/perl-Command-Runner-0.002-1.fc29.noarch.rpm | sort -f | uniq -c
      1 perl(:MODULE_COMPAT_5.26.2)
      1 perl(Capture::Tiny)
      1 perl(Command::Runner::LineBuffer)
      1 perl(Config)
      1 perl(constant)
      1 perl(IO::Select)
      1 perl(POSIX)
      1 perl(strict)
      1 perl(Time::HiRes)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -q --provides -p ../RPMS/noarch/perl-Command-Runner-0.002-1.fc29.noarch.rpm | sort -f | uniq -c
      1 perl(Command::Runner) = 0.002
      1 perl(Command::Runner::LineBuffer)
      1 perl-Command-Runner = 0.002-1.fc29
Binary provides are Ok.

Package builds in F29 (https://koji.fedoraproject.org/koji/taskinfo?taskID=26511690). Ok.

Otherwise the package is in line with Fedora and Perl packaging guidelines.

Please correct the `FIX' item and consider fixing the `TODO' item before building the packages.
Resolution: Package APPROVED.

Comment 2 Gwyn Ciesla 2018-04-23 12:55:20 UTC
(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Command-Runner

Comment 3 Jitka Plesnikova 2018-04-23 14:29:15 UTC
Thank you for the review and the repository.

Note You need to log in before you can comment on or make changes to this bug.