Hide Forgot
Description of problem: Run upgrade against containerzied ocp with openshift_release=v3.9 and openshift_image_tag=v3.10.0-0.27.0 set in inventory file. The upgrade should be exited at task [assert openshift_release in openshift_image_tag] when pre check stage. The root cause should be openshift_release set in hosts file did not take effect. It was hardcode to be 3.10. TASK [openshift_version : assert openshift_release in openshift_image_tag] ************************************************************************************************** task path: /usr/share/ansible/openshift-ansible/roles/openshift_version/tasks/first_master.yml:38 ok: [x] => { "changed": false, "msg": "All assertions passed" } TASK [openshift_version : assert openshift_release in openshift_pkg_version] ************************************************************************************************ task path: /usr/share/ansible/openshift-ansible/roles/openshift_version/tasks/first_master.yml:45 ok: [x] => { "changed": false, "msg": "All assertions passed" } TASK [openshift_version : debug] ******************************************************************************************************************************************** task path: /usr/share/ansible/openshift-ansible/roles/openshift_version/tasks/first_master.yml:53 ok: [x] => { "openshift_release": "3.10" } TASK [openshift_version : debug] ******************************************************************************************************************************************** task path: /usr/share/ansible/openshift-ansible/roles/openshift_version/tasks/first_master.yml:55 ok: [x] => { "openshift_image_tag": "v3.10.0-0.27.0" } TASK [openshift_version : debug] ******************************************************************************************************************************************** task path: /usr/share/ansible/openshift-ansible/roles/openshift_version/tasks/first_master.yml:57 ok: [x] => { "openshift_pkg_version": "-3.10*" } TASK [openshift_version : debug] ******************************************************************************************************************************************** task path: /usr/share/ansible/openshift-ansible/roles/openshift_version/tasks/first_master.yml:59 ok: [x] => { "openshift_version": "3.10" } Version-Release number of the following components: openshift-ansible-3.10.0-0.27.0.git.0.abed3b7.el7.noarch How reproducible: always Steps to Reproduce: 1. Container/rpm install ocp v3.9 2. Upgrade above ocp with following variables set in inventory file openshift_release=v3.9 openshift_image_tag=v3.10.0-0.27.0 or openshift_pkg_version=-3.10.0-0.27.0 3. Actual results: Upgrade finished. Expected results: Upgrade should abort when check that openshift_release was not in openshift_image_tag/openshift_pkg_version Additional info: Please attach logs from ansible-playbook with the -vvv flag
Marking priority to low. This actually completes what the user probably wants. I believe we were setting openshift_release during upgrades, I'll look into if the logic needs an update there.
Setting either of these values to 3.10 version seems like a clear indication of intent to upgrade. I don't think we'll get to fix this.
@Scott @Michael For this issue, the root cause was that openshift_release set in hosts file did not take effect. In v3.10, openshift_release was hardcode to be 3.10 whatever user setting this variable. So I want to have a confirm if that was what we expected? If that means "openshift_release" can be removed from inventory file?
(In reply to liujia from comment #3) > @Scott @Michael > > For this issue, the root cause was that openshift_release set in hosts file > did not take effect. In v3.10, openshift_release was hardcode to be 3.10 > whatever user setting this variable. So I want to have a confirm if that was > what we expected? If that means "openshift_release" can be removed from > inventory file? From 3.10, we did not support user to set "openshift_release" variable, am I right?
Tried this scenario in a fresh install, no such issue.
openshift_release is still recommended for installs and upgrades; Though, if not set for installs, we will default to openshift_release == actual release (in this case, 3.10). For upgrades, we hard-set openshift_release in a playbook. Setting it will probably not have much of an effect, but I recommend setting it correctly before upgrading. Probably in the future we will remove it entirely and just hard-code it; our ability to support multiple releases per openshift-ansible release is removed due to drastic changes in installer behavior.