Bug 1571122 - Review Request: perl-Dist-Zilla-Plugin-StaticInstall - Identify a distribution as eligible for static installation
Summary: Review Request: perl-Dist-Zilla-Plugin-StaticInstall - Identify a distributio...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jitka Plesnikova
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1570441
TreeView+ depends on / blocked
 
Reported: 2018-04-24 07:08 UTC by Petr Pisar
Modified: 2018-04-24 14:07 UTC (History)
2 users (show)

Fixed In Version: perl-Dist-Zilla-Plugin-StaticInstall-0.011-1.fc29
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-04-24 14:07:36 UTC
Type: ---
jplesnik: fedora-review+


Attachments (Terms of Use)

Description Petr Pisar 2018-04-24 07:08:14 UTC
Spec URL: https://ppisar.fedorapeople.org/perl-Dist-Zilla-Plugin-StaticInstall/perl-Dist-Zilla-Plugin-StaticInstall.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-Dist-Zilla-Plugin-StaticInstall/perl-Dist-Zilla-Plugin-StaticInstall-0.011-1.fc29.src.rpm
Description:
The Dist::Zilla plugin performs a number of checks against the distribution to
determine the proper value of the "x_static_install" metadata field. When set
to a true value, this indicates that it can skip a number of installation
steps (such as running Makefile.PL or Build.PL and acting on its side
effects).

Fedora Account System Username: ppisar

Comment 1 Jitka Plesnikova 2018-04-24 12:30:15 UTC
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-Dist-Zilla-Plugin-StaticInstall-0.011-1.fc29.noarch.rpm | sort | uniq -c
      1 perl(autovivification)
      1 perl(Dist::Zilla) >= 4.300039
      1 perl(Dist::Zilla::Role::InstallTool)
      1 perl(Dist::Zilla::Role::MetaProvider)
      1 perl(List::Util) >= 1.33
      1 perl(:MODULE_COMPAT_5.26.2)
      1 perl(Moose)
      1 perl(Moose::Util::TypeConstraints)
      1 perl(MooseX::Types::Moose)
      1 perl(namespace::autoclean)
      1 perl(Path::Tiny)
      1 perl(Scalar::Util)
      1 perl(strict)
      1 perl(Term::ANSIColor) >= 3.00
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-Dist-Zilla-Plugin-StaticInstall-0.011-1.fc29.noarch.rpm | sort | uniq -c
      1 perl(Dist::Zilla::Plugin::StaticInstall) = 0.011
      1 perl-Dist-Zilla-Plugin-StaticInstall = 0.011-1.fc29
Binary provides are Ok.

$ rpmlint ./perl-Dist-Zilla-Plugin-StaticInstall*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
Rpmlint is ok

The package looks good.
Approved

Comment 3 Petr Pisar 2018-04-24 14:07:36 UTC
Thank you for the review and the repository.


Note You need to log in before you can comment on or make changes to this bug.