This bug has been copied from bug #1537998 and has been proposed to be backported to 7.5 z-stream (EUS).
Tested and validated this on a RHGS cluster with targetcli-2.1.fb46-4.el7.noarch.
Was successfully able to modify the limit of /etc/target/backup/saveconfig.json, and validated that the limit set worked as expected. Was always able to have 1 config more than the limit set, but there is an existing bugzilla for the same.. will be mentioning that in my next comment.
Deleted /etc/target/backup directory, and tried to saveconfig. That directory was successfully created.
Tried saveconfig multiple times when there was no change in the targetcli configuration, and validated that backup files were not repeatedly created for every 'targetcli saveconfig' executed. A single backup file remained and continued to remain if there was no change in the configuration.
Did a change in the configuration and validated that a new backup copy was then created (when 'targetcli / saveconfig' was executed), as expected.
Positive with the validation of the patches that have gone in, in this bug.
Please feel free to move this bug to verified after a round of regression. Thanks!
Thank you Sweta and Storage-QA!
My manual testing on RHEL-7.5 with targetcli-2.1.fb46-4.el7 confirms this. We are also aware of the 1 extra backup as described in https://github.com/open-iscsi/targetcli-fb/pull/111
Our regression tests have not found any issues.
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.
For information on the advisory, and where to find the updated
files, follow the link below.
If the solution does not work for you, open a new bug report.