RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1572137 - lsmcli fs-export --*-host does not validate the value
Summary: lsmcli fs-export --*-host does not validate the value
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: libstoragemgmt
Version: 7.5
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: rc
: ---
Assignee: Tony Asleson
QA Contact: Jakub Krysl
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-04-26 09:15 UTC by Jakub Krysl
Modified: 2021-09-03 14:14 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-08-06 12:40:24 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2019:2064 0 None None None 2019-08-06 12:40:29 UTC

Description Jakub Krysl 2018-04-26 09:15:47 UTC 
Description of problem:
Using 'lsmcli fs-export' with arguments --ro-host, --rw-host or --root-host, the user can insert any value to those arguments and the command will succeed:

# lsmcli -u "sim://" fs-export --fs='FS_ID_00001' --rw-host='wrong'
ID           | FileSystem ID | Export Path       | Root Hosts | RW Hosts | RO Hosts | Options
---------------------------------------------------------------------------------------------
EXP_ID_00001 | FS_ID_00001   | /nfs_exp_503138e0 |            | wrong    |          |     

# lsmcli -u "sim://" fs-export --fs='FS_ID_00001' --rw-host='-1'
ID           | FileSystem ID | Export Path       | Root Hosts | RW Hosts | RO Hosts | Options
---------------------------------------------------------------------------------------------
EXP_ID_00001 | FS_ID_00001   | /nfs_exp_50009d14 |            | -1       |          |        

# lsmcli -u "sim://" fs-export --fs='FS_ID_00001' --ro-host='-1'
ID           | FileSystem ID | Export Path       | Root Hosts | RW Hosts | RO Hosts | Options
---------------------------------------------------------------------------------------------
EXP_ID_00001 | FS_ID_00001   | /nfs_exp_50619569 |            |          | -1       |

        
# lsmcli -u "sim://" fs-export --fs='FS_ID_00001' --ro-host='-1' --root-host='-1'
ID           | FileSystem ID | Export Path       | Root Hosts | RW Hosts | RO Hosts | Options
---------------------------------------------------------------------------------------------
EXP_ID_00001 | FS_ID_00001   | /nfs_exp_507458cd | -1         |          | -1       |   


Version-Release number of selected component (if applicable):
libstoragemgmt-1.6.1-2.el7.x86_64

How reproducible:
100%

Steps to Reproduce:
1. lsmcli -u "sim://" fs-export --fs='FS_ID_00001' --rw-host='wrong'

Actual results:
ID           | FileSystem ID | Export Path       | Root Hosts | RW Hosts | RO Hosts | Options
---------------------------------------------------------------------------------------------
EXP_ID_00001 | FS_ID_00001   | /nfs_exp_503138e0 |            | wrong    |          | 

Expected results:
lsmcli error: 'wrong' is not a valid --rw-host address/IP.

Additional info:
Comment 2 Tony Asleson 2018-12-14 21:44:31 UTC 
Just to clarify, 'wrong' is a valid hostname.  Users should be free to specify IP address or hostname.  I believe it would be a mistake to actually do a dns query or try to ping an IP address to validate that it's indeed correct.  I've submitted a patch upstream which ensures that the specified string is a valid IP or hostname, but I'm reluctant to do anything more.
Comment 4 Jakub Krysl 2018-12-17 12:21:39 UTC 
(In reply to Tony Asleson from comment #2)
> Just to clarify, 'wrong' is a valid hostname.  Users should be free to
> specify IP address or hostname.  I believe it would be a mistake to actually
> do a dns query or try to ping an IP address to validate that it's indeed
> correct.  I've submitted a patch upstream which ensures that the specified
> string is a valid IP or hostname, but I'm reluctant to do anything more.

I agree, hostname might not be reachable at the moment. Checking for hostname validity is fine, thanks.
Comment 6 Jakub Krysl 2019-01-28 17:05:39 UTC 
libstoragemgmt-1.7.2-1.el7.x86_64

# lsmcli -u "sim://" fs-export --fs='FS_ID_00001' --ro-host='*invalid*'
usage: lsmcli fs-export [-h] [-v] [-u <URI>] [-P] [-H] [-t <SEP>] [-e] [-f]
                        [-w CHILD_WAIT] [--header] [-b] [-s] --fs <FS_ID>                             
                        [--exportpath <EXPORT_PATH>] [--anonuid <ANON_UID>]                                 
                        [--anongid <ANON_GID>] [--auth-type <AUTH_TYPE>]                            
                        [--root-host <ROOT_HOST>] [--ro-host <RO_HOST>]                                                                                                                                            
                        [--rw-host <RW_HOST>]                                                                                                                                                                     
lsmcli fs-export: error: argument --ro-host: *invalid* is invalid IP or hostname
Comment 8 errata-xmlrpc 2019-08-06 12:40:24 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2019:2064
Note You need to log in before you can comment on or make changes to this bug.