Hide Forgot
Description of problem: Per documentation, the safe = 0 boolean shall make rmtree to delete even directories with insufficient permissions. However, with the 2.15 version from rh-perl526 SCl the boolean does not work and directories with insufficient permissions are left in place: :: [ 03:13:12 ] :: [ BEGIN ] :: Running 'ls -l access' celkem 0 d---------. 5 filepathtester filepathtester 41 27. dub 03.13 no drwxrwxrwx. 5 filepathtester filepathtester 41 27. dub 03.13 yes :: [ 03:13:12 ] :: [ PASS ] :: Command 'ls -l access' (Expected 0, got 0) :: [ 03:13:12 ] :: [ BEGIN ] :: Running rmtree() under regular user with safe = 1 :: actually running 'su filepathtester -c "perl -e 'use File::Path; File::Path::rmtree(\"access\", 1, 1)'"' rmdir one rmdir two rmdir three rmdir yes cannot chdir to child for access/no: Permission denied at -e line 1. rmdir access cannot remove directory for access: Directory not empty at -e line 1. :: [ 03:13:12 ] :: [ PASS ] :: Running rmtree() under regular user with safe = 1 (Expected 0, got 0) :: [ 03:13:12 ] :: [ PASS ] :: File access/yes should not exist :: [ 03:13:12 ] :: [ PASS ] :: Directory access/no should exist celkem 0 d--x--x--x. 5 filepathtester filepathtester 41 27. dub 03.13 no :: [ 03:13:12 ] :: [ BEGIN ] :: Running rmtree() under regular user with safe = 0 :: actually running 'su filepathtester -c "perl -e 'use File::Path; File::Path::rmtree(\"access\", 1, 0)'"' cannot chdir to child for access/no/one: Permission denied at -e line 1. cannot chdir to child for access/no/two: Permission denied at -e line 1. cannot chdir to child for access/no/three: Permission denied at -e line 1. rmdir no cannot remove directory for access/no: Directory not empty at -e line 1. rmdir access cannot remove directory for access: Directory not empty at -e line 1. :: [ 03:13:12 ] :: [ PASS ] :: Running rmtree() under regular user with safe = 0 (Expected 0, got 0) :: [ 03:13:12 ] :: [ FAIL ] :: Directory access should not exist Version-Release number of selected component (if applicable): rh-perl526-perl-File-Path-2.15-2.el7 How reproducible: Steps to Reproduce: 1. 2. 3. Actual results: Expected results: Additional info:
This seems to be caused by CVE-2017-6512 fix that's part of File-Path-2.13 release. Also our backport to 2.12 suffers from it.
If a directory cannot be entered (chdir), the new code will open the affected directory for reading to obtain a file descriptor to pass it to fchmod() to change the directory's permissions to retry the chdir(). But in the reported case, the directory is missing a read permission (mode 0000), thus the open() fails and the code reports an error. Obviously the code was written to deal with non-writable directories. Non-readable directories is the new issue.