Bug 1572821 - Review Request: nodejs-to-array - Turn an array like into an array
Summary: Review Request: nodejs-to-array - Turn an array like into an array
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
Depends On:
Blocks: nodejs-reviews
TreeView+ depends on / blocked
Reported: 2018-04-28 00:25 UTC by Jared Smith
Modified: 2018-05-26 15:17 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Last Closed: 2018-05-26 15:17:59 UTC
Type: ---
zebob.m: fedora-review+

Attachments (Terms of Use)

Description Jared Smith 2018-04-28 00:25:58 UTC
Spec URL: https://jsmith.fedorapeople.org/Packaging/nodejs-to-array/nodejs-to-array.spec
SRPM URL: https://jsmith.fedorapeople.org/Packaging/nodejs-to-array/nodejs-to-array-0.1.4-1.fc29.src.rpm
Description: Turn an array like into an array
Fedora Account System Username: jsmith

Comment 1 Robert-André Mauchin 🐧 2018-04-28 15:03:45 UTC
 - You need to add tap to the BR:

Exécution_de(%check) : /bin/sh -e /var/tmp/rpm-tmp.PC54iH
+ umask 022
+ cd /builddir/build/BUILD
+ cd package
+ /usr/lib/rpm/nodejs-symlink-deps /usr/lib/node_modules --check
+ /usr/bin/node -e 'require("./")'
+ NODE_ENV=test
+ /usr/bin/tap --stderr --tap test/to-array.test.js
BUILDSTDERR: /var/tmp/rpm-tmp.PC54iH: line 35: /usr/bin/tap: No such file or directory

%if 0%{?enable_tests}
BuildRequires:	mocha
BuildRequires:	npm(tap)

 - Latest version packaged
 - License ok
 - Builds in Mock
 - No rpmlint errors
 - Conforms to the Packaging Guidelines

Package approved.

Comment 2 Jared Smith 2018-05-01 13:06:12 UTC
Repo requested at https://pagure.io/releng/fedora-scm-requests/issue/6401.

Comment 3 Gwyn Ciesla 2018-05-01 13:54:16 UTC
(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/nodejs-to-array

Comment 4 Jared Smith 2018-05-26 15:17:59 UTC
Packaged in Rawhide, closing this issue

Note You need to log in before you can comment on or make changes to this bug.