Bug 1573113 - tss2: Missing build flags injection
Summary: tss2: Missing build flags injection
Alias: None
Product: Fedora
Classification: Fedora
Component: tss2
Version: 28
Hardware: Unspecified
OS: Unspecified
Target Milestone: ---
Assignee: lo1
QA Contact: Fedora Extras Quality Assurance
Depends On:
Blocks: Fedora28BuildFlags
TreeView+ depends on / blocked
Reported: 2018-04-30 08:26 UTC by Florian Weimer
Modified: 2019-05-28 19:58 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Last Closed: 2019-05-28 19:58:21 UTC
Type: Bug

Attachments (Terms of Use)

Description Florian Weimer 2018-04-30 08:26:59 UTC
tss2-1027-2.fc28.x86_64 does not use the Fedora build flags from redhat-rpm-config.  Examples from the build log:

/usr/bin/gcc -DTPM_POSIX -Wall -W -Wmissing-declarations -Wmissing-prototypes -Wnested-externs -Wformat=2 -Wold-style-definition -ggdb -O0 -c -DTPM_NUVOTON -I. -DTPM_TSS -fPIC tssfile.c

/usr/bin/gcc -DTPM_POSIX -L. -shared -Wl,-z,now -Wl,-soname,libtss.so.0 -o libtss.so.0.1 tssfile.o tsscryptoh.o tsscrypto.o tss.o tssproperties.o tssmarshal.o tssauth.o tssutils.o tsssocket.o tssdev.o tsstransmit.o tssresponsecode.o tssccattributes.o fail.o tssprint.o Unmarshal.o Commands.o CommandAttributeData.o ntc2lib.o tssntc.o 

Both CFLAGS and LDFLAGS are missing.

See https://src.fedoraproject.org/rpms/redhat-rpm-config/blob/master/f/buildflags.md for information on RPM macros and environment variables provided by the build environment.

Comment 1 Ben Cotton 2019-05-02 21:53:38 UTC
This message is a reminder that Fedora 28 is nearing its end of life.
On 2019-May-28 Fedora will stop maintaining and issuing updates for
Fedora 28. It is Fedora's policy to close all bug reports from releases
that are no longer maintained. At that time this bug will be closed as
EOL if it remains open with a Fedora 'version' of '28'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 28 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 2 Ben Cotton 2019-05-28 19:58:21 UTC
Fedora 28 changed to end-of-life (EOL) status on 2019-05-28. Fedora 28 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this

Thank you for reporting this bug and we are sorry it could not be fixed.

Note You need to log in before you can comment on or make changes to this bug.