Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.
Red Hat Satellite engineering is moving the tracking of its product development work on Satellite to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "Satellite project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs will be migrated starting at the end of May. If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "Satellite project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/SAT-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.

Bug 1574918

Summary: parameters not available to roles directly as variables: setting to enable that is missing
Product: Red Hat Satellite Reporter: Jan Hutař <jhutar>
Component: Ansible - Configuration ManagementAssignee: satellite6-bugs <satellite6-bugs>
Status: CLOSED ERRATA QA Contact: Lukas Pramuk <lpramuk>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 6.4CC: mhulan
Target Milestone: 6.4.0Keywords: Triaged
Target Release: Unused   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-10-16 19:35:20 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1449011    
Attachments:
Description Flags
Screenshot of Administer -> Settings -> Ansible none

Description Jan Hutař 2018-05-04 11:09:53 UTC
Created attachment 1431272 [details]
Screenshot of Administer -> Settings -> Ansible

Description of problem:
Parameters not available to roles directly as variables: setting to enable that is missing


Version-Release number of selected component (if applicable):
satellite-6.4.0-3.beta.el7sat.noarch
rubygem-smart_proxy_ansible-2.0.2-3.el7sat.noarch
tfm-rubygem-foreman_ansible_core-2.0.2-1.el7sat.noarch
tfm-rubygem-foreman_ansible-2.0.4-1.el7sat.noarch
ansible-2.4.2.0-2.el7.noarch


How reproducible:
always


Steps to Reproduce:
1. Have Satellite with some ansible role imported (I have used linuxhq.setup
   from Ansible Galaxy)
2. Have a host with that role assigned and add a parameter
   "setup_motd: Hello world" to it
3. Hosts -> All hosts -> <host> -> Run Ansible roles


Actual results:
Variable/parameter is not propagated into role.


Expected results:
Variable is accessible to the role.


Additional info:
Looking into inventory file generated by Satellite:

[root@sat640snap1 ~]# cat /tmp/foreman-inventories/24656315-97ca-406c-b841-7e7a7281fc1a | json_reformat
{
    "all": {
        "hosts": [
            "rhel74.example.com"
        ],
        "vars": {

        }
    },
    "_meta": {
        "hostvars": {
            "rhel74.example.com": {
                [...]
                "foreman_params": {
                    "setup_motd": "Hello world",
[...]
}

So looks like variable is there, but not as "setup_motd", but as "foreman_params.setup_motd". This is supposed to be configurable, but it is not. See attached screenshot.

Comment 2 Marek Hulan 2018-07-09 13:50:03 UTC
I see "Top level Ansible variables" with snap 10, satellite-6.4.0-10.beta.el7sat.noarch and foreman_ansible 2.2.1

but the settings seems to have no effect, params are always hidden under foreman_params key

Comment 3 Marek Hulan 2018-07-09 13:50:42 UTC
Created redmine issue https://projects.theforeman.org/issues/24209 from this bug

Comment 4 Marek Hulan 2018-07-12 15:33:02 UTC
I'm sorry I must have missed the change, I see it work as expected in mentioned snap. Moving ON_QA

Comment 5 Martin Korbel 2018-07-19 09:44:24 UTC
VERIFIED on Sat6.4#11

Reproducer via comment #0 with a small change, the value of setup_motd has to be base64 code.


> echo "Hello world" | base64
SGVsbG8gd29ybGQK


Default settings of item "Top level Ansible variables" = True (Administer > Settings > Ansible)


> cat /tmp/foreman-inventories/afeecf43-5c8c-4560-a67c-59d67e8d3a04 | json_reformat

"_meta": {
        "hostvars": {
            "host-8-253-114.host.centralci.eng.rdu2.redhat.com": {
                ...
                "foreman_params": {
                    "setup_motd": "SGVsbG8gd29ybGQK",
                    ...
                },
                ...
                "setup_motd": "SGVsbG8gd29ybGQK",
                ...
            }
         }
}


After login to client machine, we get "Hello world" in motd.



We can change "Top level Ansible variables" to False
           

> cat /tmp/foreman-inventories/d00ec3fe-6dfe-4d07-a932-40ef151a460a | json_reformat

"_meta": {
        "hostvars": {
            "host-8-253-114.host.centralci.eng.rdu2.redhat.com": {
                ...
                "foreman_params": {
                    "setup_motd": "SGVsbG8gd29ybGQK",
                    ...
                },
                ...

            }
         }
}

Comment 7 Bryan Kearney 2018-10-16 19:35:20 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2018:2927