Bug 1574973 - Review Request: rubygem-mimemagic - Fast mime detection
Summary: Review Request: rubygem-mimemagic - Fast mime detection
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
: 1297011 (view as bug list)
Depends On:
Blocks: 1206855 1574987
TreeView+ depends on / blocked
Reported: 2018-05-04 12:48 UTC by Jun Aruga
Modified: 2020-07-12 07:55 UTC (History)
4 users (show)

Fixed In Version: rubygem-mimemagic-0.3.2-1.fc29
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Last Closed: 2018-05-07 14:33:10 UTC
Type: ---
zebob.m: fedora-review+

Attachments (Terms of Use)

System ID Private Priority Status Summary Last Updated
Red Hat Bugzilla 1574987 0 medium CLOSED Review Request: rubygem-marcel - Simple mime type detection 2021-02-22 00:41:40 UTC

Internal Links: 1574987

Comment 1 Jun Aruga 2018-05-04 12:50:26 UTC
Scratch build: https://bugzilla.redhat.com/show_bug.cgi?id=1574973

Comment 2 Vít Ondruch 2018-05-04 13:01:45 UTC
Just minor nit, since you are following the most recent packaging guidelines and expanding the gem using %setup macro, you don't have to exclude the .gemspec from installation directory anymore.

Comment 3 Jun Aruga 2018-05-04 13:43:25 UTC
Thanks for the checking.
I missed to use the latest master branch's gem2rpm.
I will change like this.

$ git diff

diff --git a/rubygem-mimemagic.spec b/rubygem-mimemagic.spec
index 5270f0d..4ca1d76 100644
--- a/rubygem-mimemagic.spec
+++ b/rubygem-mimemagic.spec
@@ -60,7 +60,6 @@ popd
 %exclude %{gem_instdir}/.*
 %license %{gem_instdir}/LICENSE
-%exclude %{gem_instdir}/mimemagic.gemspec
 %exclude %{gem_cache}
@@ -70,6 +69,7 @@ popd
 %doc %{gem_instdir}/README.md

Comment 4 Robert-André Mauchin 🐧 2018-05-05 12:20:11 UTC
Package approved.

Package Review

[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

- Package contains Requires: ruby(release).

===== MUST items =====

[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "MIT/X11 (BSD like)", "Unknown or generated". 21 files have
     unknown license. Detailed output of licensecheck in
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/share/gems,
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

[x]: Platform dependent files must all go under %{gem_extdir_mri}, platform
     independent under %{gem_dir}.
[x]: Gem package must not define a non-gem subpackage
[x]: Macro %{gem_extdir} is deprecated.
[x]: Gem package is named rubygem-%{gem_name}
[x]: Package contains BuildRequires: rubygems-devel.
[x]: Gem package must define %{gem_name} macro.
[x]: Pure Ruby package must be built as noarch
[x]: Package does not contain Requires: ruby(abi).

===== SHOULD items =====

[-]: Avoid bundling fonts in non-fonts packages.
     Note: Package contains font files
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Fully versioned dependency in subpackages if applicable.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

[x]: Gem should use %gem_install macro.
[x]: Gem package should exclude cached Gem.
[x]: gems should not require rubygems package
[x]: Specfile should use macros from rubygem-devel package.
[x]: Test suite should not be run by rake.
[x]: Test suite of the library should be run.

===== EXTRA items =====

[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.

Checking: rubygem-mimemagic-0.3.2-1.fc29.noarch.rpm
rubygem-mimemagic.noarch: W: spelling-error %description -l en_US xml -> XML, ml, x ml
rubygem-mimemagic.noarch: W: no-documentation
rubygem-mimemagic-doc.noarch: E: non-executable-script /usr/share/gems/gems/mimemagic-0.3.2/test/files/application.x-ruby 644 /usr/bin/ruby 
rubygem-mimemagic-doc.noarch: W: uncompressed-zip /usr/share/gems/gems/mimemagic-0.3.2/test/files/application.zip
rubygem-mimemagic.src: W: spelling-error %description -l en_US xml -> XML, ml, x ml
rubygem-mimemagic.src: W: patch-not-applied Patch1: rubygem-mimemagic-0.3.2-use-minitest-test.patch
3 packages and 0 specfiles checked; 1 errors, 5 warnings.

Comment 5 Gwyn Ciesla 2018-05-07 13:07:08 UTC
(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rubygem-mimemagic

Comment 6 Athos Ribeiro 2020-07-12 07:55:28 UTC
*** Bug 1297011 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.