Description of problem: overriding ControllerHostnameFormat with 'CONTROLLER-%index%' fails the deployment.


Version-Release number of selected component (if applicable): 2018-05-03.2


How reproducible: 100%


Steps to Reproduce:
1. Include ControllerHostnameFormat: 'CONTROLLER-%index%' to yaml (hostname.yaml)
2. Execute overcloud_deploy.sh that includes hostname.yaml

Actual results:

2018-05-06 15:57:04Z [overcloud.AllNodesDeploySteps.ControllerDeployment_Step2.0]: CREATE_FAILED  Error: resources[0]: Deployment to server failed: deploy_status_code : Deployment exited with non-zero status code: 2
2018-05-06 15:57:04Z [overcloud.AllNodesDeploySteps.ControllerDeployment_Step2]: CREATE_FAILED  Resource CREATE failed: Error: resources[0]: Deployment to server failed: deploy_status_code : Deployment exited with non-zero status code: 2
2018-05-06 15:57:05Z [overcloud.AllNodesDeploySteps.ControllerDeployment_Step2]: CREATE_FAILED  Error: resources.ControllerDeployment_Step2.resources[0]: Deployment to server failed: deploy_status_code: Deployment exited with non-zero status code: 2
2018-05-06 15:57:05Z [overcloud.AllNodesDeploySteps]: CREATE_FAILED  Resource CREATE failed: Error: resources.ControllerDeployment_Step2.resources[0]: Deployment to server failed: deploy_status_code: Deployment exited with non-zero status code: 2
2018-05-06 15:57:06Z [overcloud.AllNodesDeploySteps]: CREATE_FAILED  Error: resources.AllNodesDeploySteps.resources.ControllerDeployment_Step2.resources[0]: Deployment to server failed: deploy_status_code: Deployment exited with non-zero status code: 2
2018-05-06 15:57:06Z [overcloud]: CREATE_FAILED  Resource CREATE failed: Error: resources.AllNodesDeploySteps.resources.ControllerDeployment_Step2.resources[0]: Deployment to server failed: deploy_status_code: Deployment exited with non-zero status code: 2

 Stack overcloud CREATE_FAILED

overcloud.AllNodesDeploySteps.ControllerDeployment_Step2.0:
  resource_type: OS::Heat::StructuredDeployment
  physical_resource_id: 23c8e6f9-d907-4f7d-bf43-532be4af5774
  status: CREATE_FAILED
  status_reason: |
    Error: resources[0]: Deployment to server failed: deploy_status_code : Deployment exited with non-zero status code: 2
  deploy_stdout: |
    ...
            "Warning: /Stage[main]/Tripleo::Profile::Pacemaker::Haproxy_bundle/Tripleo::Pacemaker::Haproxy_with_vip[haproxy_and_storage_vip]/Pacemaker::Constraint::Colocation[storage_vip-with-haproxy]/Pcmk_constraint[colo-ip-172.17.3.11-haproxy-bundle]: Skipping because of failed dependencies",
            "Warning: /Stage[main]/Tripleo::Profile::Pacemaker::Haproxy_bundle/Tripleo::Pacemaker::Haproxy_with_vip[haproxy_and_storage_mgmt_vip]/Pacemaker::Constraint::Order[storage_mgmt_vip-then-haproxy]/Pcmk_constraint[order-ip-172.17.4.10-haproxy-bundle]: Skipping because of failed dependencies",
            "Warning: /Stage[main]/Tripleo::Profile::Pacemaker::Haproxy_bundle/Tripleo::Pacemaker::Haproxy_with_vip[haproxy_and_storage_mgmt_vip]/Pacemaker::Constraint::Colocation[storage_mgmt_vip-with-haproxy]/Pcmk_constraint[colo-ip-172.17.4.10-haproxy-bundle]: Skipping because of failed dependencies"
        ]
    }
        to retry, use: --limit @/var/lib/heat-config/heat-config-ansible/34ba0375-46f6-4ca2-99e4-5438136a2d52_playbook.retry

    PLAY RECAP *********************************************************************
    localhost                  : ok=6    changed=2    unreachable=0    failed=1

    (truncated, view all with --long)
  deploy_stderr: |

Expected results: CREATE_COMPLETE


Additional info:

[stack@undercloud-0 ~]$ openstack server list
+--------------------------------------+--------------+--------+------------------------+----------------+------------+
| ID                                   | Name         | Status | Networks               | Image          | Flavor     |
+--------------------------------------+--------------+--------+------------------------+----------------+------------+
| c3afed28-9e7c-4415-8500-d077020141d4 | CONTROLLER-1 | ACTIVE | ctlplane=192.168.24.21 | overcloud-full | controller |
| d0468bda-e7dc-4e11-9a9f-f57b38811514 | ceph-2       | ACTIVE | ctlplane=192.168.24.19 | overcloud-full | ceph       |
| 9b763904-33da-4d35-9ade-5794b74b6f1c | CONTROLLER-2 | ACTIVE | ctlplane=192.168.24.20 | overcloud-full | controller |
| 87b200fa-d2c6-49d5-a806-fd7239d9f83d | CONTROLLER-0 | ACTIVE | ctlplane=192.168.24.8  | overcloud-full | controller |
| 0acbc77b-2523-47ce-a571-4fa2cbed96fb | compute-1    | ACTIVE | ctlplane=192.168.24.15 | overcloud-full | compute    |
| 69c67c96-6c7f-4599-86ee-97dce0cb075e | ceph-0       | ACTIVE | ctlplane=192.168.24.17 | overcloud-full | ceph       |
| 337a489f-60ec-42bd-8119-3d85a99d73e5 | compute-0    | ACTIVE | ctlplane=192.168.24.6  | overcloud-full | compute    |
| bf245d9e-dd59-4f11-91dc-0820f05cbd0b | ceph-1       | ACTIVE | ctlplane=192.168.24.10 | overcloud-full | ceph       |
+--------------------------------------+--------------+--------+------------------------+----------------+------------+

[heat-admin@controller-0 ~]$ hostname
controller-0

[heat-admin@controller-0 ~]$ sudo hiera -c /etc/puppet/hiera.yaml bootstrap_nodeid
CONTROLLER-0

[heat-admin@controller-0 ~]$ sudo facter hostname
controller-0

[heat-admin@controller-0 ~]$ sudo grep -r CONTROLLER /etc/puppet/hieradata/ | head
/etc/puppet/hieradata/controller.json:    "fqdn_canonical": "CONTROLLER-0.localdomain",
/etc/puppet/hieradata/controller.json:    "fqdn_ctlplane": "CONTROLLER-0.ctlplane.localdomain",
/etc/puppet/hieradata/controller.json:    "fqdn_external": "CONTROLLER-0.external.localdomain",
/etc/puppet/hieradata/controller.json:    "fqdn_internal_api": "CONTROLLER-0.internalapi.localdomain",
/etc/puppet/hieradata/controller.json:    "fqdn_management": "CONTROLLER-0.management.localdomain",
/etc/puppet/hieradata/controller.json:    "fqdn_storage": "CONTROLLER-0.storage.localdomain",
/etc/puppet/hieradata/controller.json:    "fqdn_storage_mgmt": "CONTROLLER-0.storagemgmt.localdomain",
/etc/puppet/hieradata/controller.json:    "fqdn_tenant": "CONTROLLER-0.tenant.localdomain",
/etc/puppet/hieradata/all_nodes.json:        "CONTROLLER-0.internalapi.localdomain",
/etc/puppet/hieradata/all_nodes.json:        "CONTROLLER-1.internalapi.localdomain",