We need to pass all `deploy` arguments to `upgrade prepare/converge` commands, not just -e parameters. (See bug 1571437 for possible effects if some params are left out.) This is most important for network data, roles data, and any role count parameters, but prepare/converge commands inherit from deploy, so we should simply carry over all.
There's a gotcha that some parameters were deprecated -- the --ntp-server and all --*-scale parameters. These should be converted into environment files, see
The commands which should receive all `deploy` args:
Once this is properly triaged, please make sure to add Documentation keyword.
I ended up including a table with the deprecated CLI options:
And included the environment file for it with the ffu commands. E.g.
I also mentioned the use of --roles-file but on advice from Marius Cornea not to include the --network-files param for a couple of reasons (mainly OSP10 users will only have the default networks and we don't support changing networks in the middle of the upgrade).
How does all this sound to you? Is there anything else I should mentioned?
i looked at the doc parts you linked and i think all is good, thanks for making the edits.