Bug 1577711 - "uninstall.yml" playbooks will wipe out docker storage all VGs included "docker" into the name.
Summary: "uninstall.yml" playbooks will wipe out docker storage all VGs included "dock...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Installer
Version: 3.9.0
Hardware: x86_64
OS: Unspecified
medium
medium
Target Milestone: ---
: 3.11.0
Assignee: Michael Gugino
QA Contact: sheng.lao
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-05-14 03:09 UTC by Daein Park
Modified: 2018-10-11 07:20 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-10-11 07:20:00 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2018:2652 0 None None None 2018-10-11 07:20:21 UTC

Description Daein Park 2018-05-14 03:09:47 UTC
Description of problem:
The VGs named "docker" will be removed by "uninstall.yml" playbooks.
It needs the warning on the document or release notes because someone who was used OCPv3.7 or below one does not expect the VG will removed. 

Additionally, I think the detected conditions which remove docker storage VGs need to be more specific conditions. When the docker storage named other something not included docker string, it's not removed and having potential risks that remove the other one not to related Docker storage VGs. Such as other system and OS VGs included "docker" string into the ones.


Version-Release number of the following components:
rpm -q openshift-ansible

  openshift-ansible-3.9.14-1.git.3.c62bc34.el7.noarch

rpm -q ansible

  ansible-2.4.3.0-1.el7ae.noarch

ansible --version

  ansible 2.4.3.0
    config file = /etc/ansible/ansible.cfg
    configured module search path = [u'/root/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
    ansible python module location = /usr/lib/python2.7/site-packages/ansible
    executable location = /usr/bin/ansible
    python version = 2.7.5 (default, May  3 2017, 07:55:04) [GCC 4.8.5 20150623 (Red Hat 4.8.5-14)]


How reproducible:

Steps to Reproduce:
1. run "/usr/share/ansible/openshift-ansible/playbooks/adhoc/uninstall.yml" after installing OCPv3.9 configured the docker storage setup.
2.
3.

Actual results:
Please include the entire output from the last TASK line through the end of output if an error is generated


When OCP redeploy after uninstall.yml, the installation will be failed.

~~~
Failure summary:

  1. Hosts:    10.0.0.1, 10.0.0.2, 10.0.0.3
     Play:     OpenShift Health Checks
     Task:     Run health checks (install) - EL
     Message:  One or more checks failed
     Details:  check "docker_storage":
               Docker storage drivers 'overlay' and 'overlay2' are only supported with
               'xfs' as the backing storage, but this host's storage is type 'extfs'.
~~~


Expected results:

If this function is new feature, we need to notice it, and warn the uninstall.yml will remove the existing docker VGs and explain the condition which select the VGs included the "docker" on the name for review the system before uninstall.

Additional info:
Please attach logs from ansible-playbook with the -vvv flag

Comment 1 Scott Dodson 2018-08-01 20:03:38 UTC
https://github.com/openshift/openshift-ansible/pull/9270 makes docker uninstall opt-in avoiding this problem

Comment 3 sheng.lao 2018-08-02 15:06:03 UTC
version: 
# git describe 
openshift-ansible-3.11.0-0.10.0-35-g4ffd859

Comment 5 errata-xmlrpc 2018-10-11 07:20:00 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2018:2652


Note You need to log in before you can comment on or make changes to this bug.