Bug 157825 - [PATCH] Indic languages's Rendering is incorrect
[PATCH] Indic languages's Rendering is incorrect
Status: CLOSED RAWHIDE
Product: Fedora
Classification: Fedora
Component: yelp (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Matthew Barnes
: i18n, Reopened
Depends On:
Blocks: FC6Blocker
  Show dependency treegraph
 
Reported: 2005-05-16 06:24 EDT by A S Alam
Modified: 2007-11-30 17:11 EST (History)
3 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2006-09-06 11:24:22 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)
patch for yelp.spec (705 bytes, patch)
2006-09-06 03:58 EDT, Akira TAGOH
no flags Details | Diff

  None (edit)
Description A S Alam 2005-05-16 06:24:27 EDT
Description of problem:
after login Language Envirnoment, Open Yelp,


Version-Release number of selected component (if applicable):
2.9.3

How reproducible:
everytime

Steps to Reproduce:
1.Alt+F2
2.type yelp
3.
  
Actual results:
Rendering for Punjabi is incorrect

Expected results:
Rendering should be correct

Additional info:
1) Interface is in English, although, /usr/share/locale/pa/LC_MESSAGES/yelp.mo
file is present
2) Rendering is Like Mozilla before MOG_ENABLE_PANGO varible
Comment 2 A S Alam 2005-06-29 23:37:06 EDT
I confirmed this problem at FC4.
Comment 3 A S Alam 2005-09-10 08:20:01 EDT
for latest update yelp-2.12.0, rendering is still incorrect!
Comment 4 A S Alam 2006-08-04 01:02:20 EDT
problme exist for all Indic locales with following version in Fedora Core Rawhide:
yelp-2.15.5-1
Comment 5 Akira TAGOH 2006-08-28 01:31:51 EDT
invoking yelp with MOZ_ENABLE_PANGO=1 would help in this case. so making an
wrapper script may be easier way to solve this issue?
Comment 6 Christopher Aillon 2006-08-28 23:15:47 EDT
(In reply to comment #5)
> invoking yelp with MOZ_ENABLE_PANGO=1 would help in this case. so making an
> wrapper script may be easier way to solve this issue?

Pango is now on by default, so that should not do anything at all.  The only
environment variable that is taken now by gecko-based browsers in rawhide is
MOZ_DISABLE_PANGO.  If that is set in the environment, then pango will obviously
be disabled.  Is it possible that this is lingering in a .bashrc file or something?
Comment 7 Akira TAGOH 2006-08-29 04:58:05 EDT
Ok, found it. it was yelp fault and in src/yelp-main.c:

                /* workaround for bug #329461 */
                env = g_getenv ("MOZ_ENABLE_PANGO");

                if (env == NULL ||
                    *env == '\0' ||
                    g_str_equal(env, "0"))
                        {
                                g_setenv ("MOZ_DISABLE_PANGO", "1", TRUE);
                        }

I'm not sure if that problem still happens on the latest GtkMozEmbed though (at
least it looks good after some testing). if that's ok, can we just get rid of
the above code? if not, we need to turn it on for only Indic.

Comment 8 Matthias Clasen 2006-08-29 08:20:10 EDT
hmm, according to the mentioned bug, epiphany has the same code to turn off
pango rendering. We need to verify if the problem still exists, and if so,
fix it before removing the hack from both.
Comment 9 Matthias Clasen 2006-08-29 16:00:33 EDT
I have turned on pango by default in yelp and epiphany now.
Comment 10 Akira TAGOH 2006-09-05 00:18:16 EDT
patch wasn't applied it seems ;)
Comment 11 Matthias Clasen 2006-09-05 09:47:43 EDT
Patch is definitively applied in the current rawhide package.

What problems are you seeing ?
Comment 12 A S Alam 2006-09-06 02:11:38 EDT
it is not working with latest Rawhide, tested  with following package:
yelp-2.16.0-1.fc6
Additional Information:

MOZ_ENABLE_PANGO=1 yelp
working fine
Comment 13 Akira TAGOH 2006-09-06 03:58:35 EDT
Created attachment 135635 [details]
patch for yelp.spec

(In reply to comment #11)
> Patch is definitively applied in the current rawhide package.
> 
> What problems are you seeing ?

Or you may forgot to commit your changes on your working repository to the
server perhaps. I've attached a patch to the latest revision of yelp.spec
anyway.
Comment 14 Matthias Clasen 2006-09-06 11:19:57 EDT
gah, I looked at the epiphany spec...
Comment 15 Matthias Clasen 2006-09-06 11:24:22 EDT
should be fixed in 2.16.0-2.fc6

Note You need to log in before you can comment on or make changes to this bug.